Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNDERTOW-1593] Add ActiveRequestTrackingHandler #1709

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UNDERTOW-1593] Add ActiveRequestTrackingHandler #1709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions core/src/test/java/io/undertow/server/handlers/ActiveRequestTrackerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,8 @@ public void testRequestTracking() throws InterruptedException {
t.start();

List<RequestStatistics> trackedRequests = handler.getTrackedRequests();
int attempts = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this PR is attempting to do. It adds a variable that doesn't seem to be read and edits a comment. Were some changes not added?


// This test is somewhat time-sensitive in that an in-flight request is needed to verify that the handler
// is correctly tracking and returning active requests. To that end, the test submits a request in a
// Thread (above) to let the request be made in a background thread while the main thread attempts to
// get the active request information. The delay handler waits for termination via latch and
// meanwhile this thread tries to retrieve the request statistics. There is a max waiting time of 5 seconds.
try {
Expand Down
Loading