Search Adjustments from 8/25 review

[as1729]

Search adjustments:
Priority post-launch issues can be found here: #2040
Other issues that were determined to be non-blockers for launch are separated into separate tickets.

• need to hard refresh to see feature flag [update 10/2 - seems like this is not an issue for most folks]
• @as1729 Add "All Bills" option to the bill multiselect
• @as1729 change "Bill" filed to "Appropriation Bill"
• add border to bottom of table
• make pressing the enter key execute the search when the advanced search panel is open
• I’m able to save a search without entering any criteria - should be required to enter one criteria
• @as1729 Reduce font side for side panel title "New Search" "Edit Search" etc.
• @as1729 Add 10px padding below include / export csv row and top of table
• @as1729 Reduce padding between "My Saved Search" and "New Search" button
• @as1729 Reduce padding between title of saved search and criteria in saved search panel
• @as1729 Increase padding at top and bottom of cells in saved search drawer
• @as1729 - update pagination styling

Performance Testing

• Create 50 x 650 saved searches and monitor successful completion of the email notifications cron job.
• [live in staging] @jakekreider Remove search total calculations from pagination (search totals and page totals will not calculate or display) -

Final Readiness known-items

• [not started] @as1729 Migrate one saved search per user #1662
• [done] @as1729 List of all current user emails #1828
• [done] Create PR for Turn on production feature flag #1789

Bugs to resolve by Launch Date

• [live in staging] @as1729 Refresh the hard-coded list of items in the Appropriations Bill Section. (Details: run a query on production to get latest bills.)
• Remove Dashboard table - Hide dashboard stats, skip separate query for total count #1979
• [live in staging] @replicantSocks Unit tests for Edit search endpoint
• [live in staging] @as1729 Add Training Guide to profile menu dropdown #1930
• [live in staging] @as1729 Email notification generation is not predictable and seems broken. The endpoint is returning a 500 error which needs to be resolved.
  • [live in staging] notifications not returning same results as search (even after filtering posted dates). Looks like the query for a saved search sends the includeKeywords filter as an array, but it is not being saved as an array, and so there's a difference between searching and digest notifications.
• [live in staging] Grants sending multiple email notifications
• @jakekreider Including phrased search in keywords turns search into "and" search rather than "or" #1919
• [live in staging] @as1729 Closed grants showing as posted #1916
• [live in staging] @as1729 Award Ceiling order-by does not work. Try: Include: electric or vehicle; Agency Code: DOL
• [live in staging] @as1729 export csv not always exporting up to 500 grants in search - search for "fund" and opp status of "posted" - you get 1473 total grants. when you export this, you get a file with only 301 grants
• [live in staging] @as1729 Remove the “View New Grants” in the email that links to the Browse grants page. It should either deep-link to a grant or not exist at all.
• [live in staging] @as1729 remove "forecasted" as a selection option from Opportunity Status field in search panel
• [live in staging] @as1729 By default, grants queries should ignore Closed/Archived grants unless explicitly specified via checkbox
• [live in staging] @as1729 Consolidate Closed and Archived Opportunity Status
• Include phrase-only search is returning a 500 error. Try: Include: electric vehicle
• Move pagination to the top of the Grants table
• @as1729 Add index to Opportunity Status field
• @as1729 Need to remove review status from side panel
• @as1729 Choosing "All Bills" returns zero results. This needs to be made undefined when passed to the backend.

Grant Ingest Deployment Prerequisites

• [live in staging] @as1729 put email notifications features behind a feature flag

Due by 2023-08-30 at noon ET

• @jakekreider “Edit” saved search is inconsistent. Sometimes the values are not actually getting saved
  • Save and apply does not appear to have saved search
• @jakekreider Delete of a saved search not working - no confirmation prompt and saved search not deleting
  • Deleting from the drawer applies the deleted search to the grants table
  • Delete Saved Search - delete from drawer applies the search, expecting table to return to all grants after a search is deleted.
  • Deleted search does not disappear from panel until after page is refreshed
  • Delete keywords and check that it’s reflected in Browse Grants
  • Edit Saved Search from above table - not working
  • Edit Saved Search from drawer - applies edits but does not save edits
  • Apply saved search from drawer - CW, does not apply

General Bugs due by 2023-09-07

• @replicantSocks Emit an error message when you’re prevented from creating a new search with the same name as a previous saved search - see ticket As a user applying filters to a search, I want to be able to save that search so I can re-use it on a recurring basis. #1369 for intended functionality
• @TylerHendrickson backfill needed for funding type and bill (right now searching by either gives empty results)
• @as1729 My Grants - paginated numbers not showing the correct total (i.e. 9 of 31 when only 9 grants are showing)
• @as1729 Eligibility - when you select an option from a multi-select, you can X out of selected option
• @as1729 Power of 2 issues when clicking the same multiselect option on Eligibility Codes
• @as1729 My grants tab pulling grants across tenants. This should be scoped to agency.
• @replicantSocks Export to CSV - Make sure we are able to export the first 500 rows of any search criteria
• @as1729 Unit tests for paginated grants endpoint
• @as1729 Make bill field as a drop-down
• my saved searches panel is not paginated (it scrolls which is okay but might impact if more than 50 searches, 51 and over may disappear)
• @TylerHendrickson opportunity status field not updating from grants.gov so don't really reflect status if it's changed since it came in. This is resolved by pulling in grants via grants-ingest rather than the scraper.
• @as1729 what should paginated number show? Decided to show total grants only.
• @as1729 The sidebar ends up creating a horizontal scroll : solution, trunkate pills and wrap list. see figma:
• Interested Agencies is broken. See error: error: select distinct "grants".* from "grants" left join "grants_interested" on "grants"."grant_id" = "grants_interested"."grant_id" order by "grants_interested"."grant_id" asc, "grants"."grant_id" asc limit $1 - for SELECT DISTINCT, ORDER BY expressions must appear in select list
• [not doing] Dashboard totals don't seem to be displaying correctly (i.e. $0 is displaying as the total when there are interested grants, and a large $ amount is showing for rejections when there are 0 rejected grants) https://files.slack.com/files-pri/TVDP74XAM-F05SR4ABXBJ/screenshot_2023-09-12_at_4.23.24_pm.png Fixed using: Hide dashboard stats, skip separate query for total count #1979