Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add error message when grants fetch fails #2001

Merged
merged 4 commits into from
Oct 3, 2023
Merged

fix: add error message when grants fetch fails #2001

merged 4 commits into from
Oct 3, 2023

Conversation

as1729
Copy link
Contributor

@as1729 as1729 commented Sep 29, 2023 •
edited
Loading

Ticket #1829

Description

Screenshots / Demo Video

Testing

Automated and Unit Tests

  • Added Unit tests

Manual tests for Reviewer

  • Added steps to test feature/functionality manually

Checklist

  • Provided ticket and description
  • Provided screenshots/demo
  • Provided testing information
  • Provided adequate test coverage for all new code
  • Added PR reviewers

@as1729 as1729 mentioned this pull request Sep 29, 2023
Open
63 tasks
@as1729 as1729 enabled auto-merge (squash) October 3, 2023 16:46
replicantSocks
replicantSocks approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@replicantSocks replicantSocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just adding a note here that this won't handle the inconsistent state that can result from an error and based on our discussion, we'll handle that separately.

@codeclimate
Copy link

codeclimate bot commented Oct 3, 2023

Code Climate has analyzed commit 1b2a0cc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 55.9% (0.0% change).

View more on Code Climate.

@as1729 as1729 merged commit 6d9dbb7 into _staging Oct 3, 2023
4 checks passed
@as1729 as1729 deleted the as/add-error-message branch October 3, 2023 16:49
@ClaireValdivia ClaireValdivia mentioned this pull request Oct 6, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@replicantSocks replicantSocks replicantSocks approved these changes

@TylerHendrickson TylerHendrickson TylerHendrickson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@as1729 @TylerHendrickson @replicantSocks