fix: ensures opportunity_status is up to date

[as1729]

Ticket #1829

Description

• Ensures archive_date is set when we capture new grants
• Calculates opportunity_status at query-time based on the values of open_date close_date and archive_date

Screenshots / Demo Video

Before

After

Testing

Automated and Unit Tests

• Added Unit tests

Manual tests for Reviewer

• Added steps to test feature/functionality manually

Checklist

• Provided ticket and description
• Provided screenshots/demo
• Provided testing information
• Provided adequate test coverage for all new code
• Added PR reviewers

[as1729]

@TylerHendrickson can you give a preliminary review on whether this is the approach you were expecting to see. Since these fields are in text type in the database we either need to change that or cast it to ::timestamp

[TylerHendrickson]

Requesting a small change for using date type instead of timestamp without time zone, which is a small difference but I think is more intuitive.

Also, do you think it's worth doing a multi-phase migration as we discussed for the award_ceiling and award_floor migrations? Would be something like

-- Initial migration
ALTER TABLE grants
ADD COLUMN open_date_new date USING open_date::date, 
ADD COLUMN close_date_new date using close_date::date;

-- Second step
ALTER TABLE grants
RENAME COLUMN open_date TO open_date_old,
RENAME COLUMN open_date_new TO open_date,
RENAME COLUMN close_date TO close_date_old,
RENAME COLUMN close_date_new TO close_date;

-- Last step
ALTER TABLE grants
DROP COLUMN open_date_old,
DROP COLUMN close_date_old;

[codeclimate]

Code Climate has analyzed commit 9196d90 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 77.7% (50% is the threshold).

This pull request will bring the total coverage in the repository to 55.3%.

View more on Code Climate.