Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add April 2024 monthly call #2671

Merged
merged 4 commits into from
May 14, 2024
Merged

Add April 2024 monthly call #2671

merged 4 commits into from
May 14, 2024

Conversation

finekatie
Copy link
Contributor

@finekatie finekatie commented May 13, 2024

Added April Monthly call content to the Monthly Calls page.

Note: Also removed a period from the March MC description as we are not including periods in the format there.

Summary

This purpose of this PR is to update the monthly call page to include a video (and supplemental information) for the April 2024 monthly call. This update will keep the page relevant and timely.

Related issue

Closes #2632

Preview link

Preview link: https://federalist-ead78f8d-8948-417c-a957-c21ec5617a57.sites.pages.cloud.gov/preview/uswds/uswds-site/kf-MCpageupdate-April/about/monthly-calls/

Problem statement

The April 2024 event needs to be added to the USWDS monthly calls page.

Solution

This action will add the April 2024 event to the monthly call page so that the USWDS community can enjoy it!

Testing and review

Please proof the new content and make sure it's formatted correctly.

Added April Monthly call content and removed a period from the March MC description.
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I had one suggestion to remove the missing_script data key since it looks like the event page now has the script.

Also, there is currently a build failure related to snyk that I am working on fixing with #2672. We'll try to have that merged ASAP (hopefully tomorrow).

_data/monthly-calls.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Note

The snyk build error will be resolved with PR #2672 Update: I merged in the snyk fix in 4339e3c

@finekatie finekatie requested a review from thisisdano May 14, 2024 13:45
@thisisdano
Copy link
Member

Merging over pa11y crash

@thisisdano thisisdano merged commit aa5f4d7 into main May 14, 2024
8 of 11 checks passed
@thisisdano thisisdano deleted the kf-MCpageupdate-April branch May 14, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add April Monthly Call content to Monthly Calls page
3 participants