Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration fix #242

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Migration fix #242

merged 3 commits into from
Apr 16, 2024

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Apr 15, 2024

What does this PR change?

Fix failure in migration: awk is not installed in migration image.

Test coverage

  • No tests: manual tests only

  • DONE

Links

Issue(s): #

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Before you merge

Check How to branch and merge properly!

@cbosdo cbosdo requested a review from mbussolotto April 15, 2024 14:15
@rjmateus
Copy link
Member

@cbosdo did you miss a rebase on this one, or branched from the wrong location? It looks to also included translations

Copy link
Member

@mbussolotto mbussolotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbosdo
Copy link
Contributor Author

cbosdo commented Apr 15, 2024

@cbosdo did you miss a rebase on this one, or branched from the wrong location? It looks to also included translations

It's based on l10n branch since this one will be merged first. This will avoid conflicts later

The cobbler authentication should be named
uyuni_authentication_endpoint. A remnant from old code was lingering and
broke migration and upgrade.
@deneb-alpha deneb-alpha merged commit 6e1326a into main Apr 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants