Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add govulncheck workflow #471

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Add govulncheck workflow #471

merged 2 commits into from
Nov 4, 2024

Conversation

cbosdo
Copy link
Contributor

@cbosdo cbosdo commented Oct 21, 2024

What does this PR change?

run govulncheck on each PR

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Before you merge

Check How to branch and merge properly!

@cbosdo cbosdo force-pushed the govulncheck branch 3 times, most recently from 306745b to da60118 Compare October 21, 2024 10:11
@cbosdo
Copy link
Contributor Author

cbosdo commented Oct 21, 2024

I have to bump to go 1.21 to run govulncheck as it doesn't build on 1.20. I still have to get go 1.21 to be used on OBS builds for AlmaLinux 8

@cbosdo cbosdo force-pushed the govulncheck branch 3 times, most recently from e4b5bb7 to cce4dac Compare October 22, 2024 08:27
@cbosdo
Copy link
Contributor Author

cbosdo commented Nov 4, 2024

Adding the go1.21 bump again now that OBS build with it on AlmaLinux 8

@deneb-alpha
Copy link
Contributor

Adding the go1.21 bump again now that OBS build with it on AlmaLinux 8

what changed about that stream? do you know if autobuild did an update of the stream or something different?

@cbosdo
Copy link
Contributor Author

cbosdo commented Nov 4, 2024

Adding the go1.21 bump again now that OBS build with it on AlmaLinux 8

what changed about that stream? do you know if autobuild did an update of the stream or something different?

Quoting the answer from autobuild:

the public key of the appstream changed, so the DoD (which still had the old key) was not working.

@cbosdo cbosdo merged commit 939959e into uyuni-project:main Nov 4, 2024
7 checks passed
@cbosdo cbosdo deleted the govulncheck branch November 4, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants