podman upgrade fixes #491
Merged
podman upgrade fixes #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaannz
approved these changes
Nov 12, 2024
Hub upgrade was restarting the existing instance, which is fine for cases where the user didn't set any replica for it. Coco's upgrade was scaling to the number of replicas passed as parameters, which doesn't work if the user didn't set any and has running instances. This merges both: if no replica is set, just restart the enabled ones. Otherwise scale to whatever the user provided.
The systemd config needs to be reloaded between the config files cleanup step and the service upgrade as that one starts with a systemctl cat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
systemctl daemon-reloadTest coverage
No tests: still needs some more mockable layers to be working.
DONE
Links
Issue(s): https://github.com/SUSE/spacewalk/issues/25770 https://github.com/SUSE/spacewalk/issues/25771
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!