Add saline container #499
Merged
Add saline container #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhestkov
force-pushed
the
add-saline
branch
6 times, most recently
from
70a28f9
to
d08eb63
Compare
vzhestkov
force-pushed
the
add-saline
branch
from
d08eb63
to
cec9420
Compare
mbussolotto
reviewed
Nov 25, 2024
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package saline |
There was a problem hiding this comment.
the code for coco attestation is quite similar to this one, maybe we should do some refactoring to share more code between all the services
There was a problem hiding this comment.
Maybe not just with coco, but also with HubXmlrpc, but to be fair I'm not deeply familiar with Go yet, so I would suggest to have such refactoring as a separate PR especially as this one intended to implement just Saline container and not affecting the others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Implements saline container and service deployment.
Test coverage
Unit tests were added
DONE
Links
Issue(s): #
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!