Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hello world service #2057

Merged
merged 16 commits into from
Oct 11, 2023
Merged

Remove hello world service #2057

merged 16 commits into from
Oct 11, 2023

Conversation

angrybayblade
Copy link
Contributor

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.

Fixes

If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run services that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

@jmoreira-valory
Copy link
Collaborator

jmoreira-valory commented Oct 9, 2023

@angrybayblade: UPDATE Changes related to docs are now on PR #2084 , rebased on this branch. So merge order should be 2084 --> this branch --> main

@angrybayblade angrybayblade force-pushed the chore/remove-hello-world branch from ed73e9a to a9c5442 Compare October 10, 2023 12:55
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b061dff) 94.22% compared to head (64cf7a8) 94.13%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2057      +/-   ##
==========================================
- Coverage   94.22%   94.13%   -0.09%     
==========================================
  Files         262      254       -8     
  Lines       15989    15757     -232     
==========================================
- Hits        15065    14833     -232     
  Misses        924      924              
Flag Coverage Δ
unittests 94.13% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@angrybayblade angrybayblade merged commit 3e9b1fe into main Oct 11, 2023
23 of 24 checks passed
@DavidMinarsch DavidMinarsch deleted the chore/remove-hello-world branch November 25, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants