-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hello world service #2057
Conversation
@angrybayblade: UPDATE Changes related to docs are now on PR #2084 , rebased on this branch. So merge order should be 2084 --> this branch --> main |
ed73e9a
to
a9c5442
Compare
…hore/remove-hello-worl-docs
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2057 +/- ##
==========================================
- Coverage 94.22% 94.13% -0.09%
==========================================
Files 262 254 -8
Lines 15989 15757 -232
==========================================
- Hits 15065 14833 -232
Misses 924 924
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…hore/remove-hello-worl-docs
Remove hello-world docs
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an
x
in the box that appliesChecklist
Put an
x
in the boxes that apply.main
branch (left side). Also you should start your branch off ourmain
.