Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hello world packages and documentation #2077

Closed
wants to merge 28 commits into from
Closed

Remove hello world packages and documentation #2077

wants to merge 28 commits into from

Conversation

jmoreira-valory
Copy link
Collaborator

@jmoreira-valory jmoreira-valory commented Oct 4, 2023 •
edited
Loading

Proposed changes

  • Remove hello world packages.
  • Remove hello world documentation and update links.
  • Fixed doc linter scripts to work with source files in external repositories.
  • Minor fixes/restructure on documentation.

Important note:
CI will fail due to missing links. This is expected until documentation is uploaded to production and links are available.

Also, there is a CI issue unrelated to the changes in this PR.

Fixes

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

  • Non-breaking fix (non-breaking change which fixes an issue)
  • Breaking fix (breaking change which fixes an issue)
  • Non-breaking feature (non-breaking change which adds functionality)
  • Breaking feature (breaking change which adds functionality)
  • Refactor (non-breaking change which changes implementation)
  • Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the main branch (left side). Also you should start your branch off our main.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have locally run services that could be impacted and they do not present failures derived from my changes
  • Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
  • Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Further comments

@jmoreira-valory jmoreira-valory changed the title [WIP] Remove hello world packages Remove hello world packages Oct 5, 2023
@jmoreira-valory jmoreira-valory changed the title Remove hello world packages Remove hello world packages and documentation Oct 6, 2023
@jmoreira-valory jmoreira-valory mentioned this pull request Oct 9, 2023
Merged
13 tasks
angrybayblade
angrybayblade reviewed Oct 10, 2023
View reviewed changes
docs/delegate_call.md
@@ -1,3 +0,0 @@
## Delegate call vs call
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this deleted?

Copy link
Collaborator Author

@jmoreira-valory jmoreira-valory Oct 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'ts not deleted: the contents of the file are moved to the FAQ, because it makes more sense there. Since it was a minor change, I did on this PR instead of opening a new one.

docs/ethereum_specifics.md
@@ -1,13 +0,0 @@
## EIP-1559 Transactions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

angrybayblade
angrybayblade reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@angrybayblade angrybayblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a mess, so many things going on at the same time. Please try and create multistage PR next time for a task like this.

@jmoreira-valory
Copy link
Collaborator Author

Addressed in #2057 and #2084

@DavidMinarsch DavidMinarsch deleted the feat/remove_hello_world branch November 25, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angrybayblade angrybayblade angrybayblade left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmoreira-valory @angrybayblade