Skip to content
This repository has been archived by the owner on Sep 3, 2024. It is now read-only.

LFSR #1

Merged
merged 6 commits into from
Mar 10, 2024
Merged

LFSR #1

merged 6 commits into from
Mar 10, 2024

Conversation

nblei
Copy link
Contributor

@nblei nblei commented Mar 10, 2024

I've added a Galois linear feedback shift register.

It is parameterizable by width of the shift register (SIZE), as well as the taps (TAPVEC).

Default tap vectors are given for LFSRs of size 2 through 64.

I have also added a SV testbench, and I have tested that the default LFSRs have maximal period for sizes up to 24 bits.

Copy link
Contributor

@dalance dalance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.
I added some comments.

src/lfsr/lfsr_galois.veryl Outdated Show resolved Hide resolved
src/lfsr/lfsr_galois.veryl Outdated Show resolved Hide resolved
src/lfsr/lfsr_galois.veryl Outdated Show resolved Hide resolved
@dalance
Copy link
Contributor

dalance commented Mar 10, 2024

The SV testbench is useful as reference for Veryl's unit test feature.
I'll focus that the testbench can be written by Veryl.
It will be minimum viable product of unit test feature.

@nblei
Copy link
Contributor Author

nblei commented Mar 10, 2024

The SV testbench is useful as reference for Veryl's unit test feature. I'll focus that the testbench can be written by Veryl. It will be minimum viable product of unit test feature.

Is Veryl unit testing a feature that currently exists or one that you're working on? If the former, could you point me to the documentation on it?

@dalance
Copy link
Contributor

dalance commented Mar 10, 2024

Is Veryl unit testing a feature that currently exists or one that you're working on? If the former, could you point me to the documentation on it?

Not yet. So I'll merge this PR as is.
After implementing unit test feature, I want to translate the testbench to Veryl.

@dalance dalance merged commit fc6243a into veryl-lang:main Mar 10, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants