Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Managed Identity support for Image Pull #240

Open
wants to merge 116 commits into
base: master
Choose a base branch
from

Conversation

suselva
Copy link
Contributor

@suselva suselva commented Jul 20, 2022

Ability to use MI for image pulls

Overview:

Currently customers must pass in their ACR credentials to get container images pulled onto ACI. This introduces concerns from customers that the credentials may be compromised. Customers would like to be able to authenticate with ACR using an assigned managed identity.

ACI Support:

Specify the properties of Azure container registry by including the imageRegistryCredentials property in the container group definition.

ImageRegistryCredential

image

image

Prerequisites

• MI should have create resource permission on at least the Resource Group Level to be able to create an ACI Resource.
• MI should have “ACRPull” access on the ACR.
• Assign MI as Kubelet Identity on the AKS Cluster. Kubelet Identity is available on the nodepool VMSS as a user assigned identity, which is used for authorizing with ACI to create container groups.

Work Required

  1. MI to be added as ContainerGroupIdentity to be passed to ACI.
  2. Infer Managed Identity using a GET call against ManagedCluster and use ACR Server name from the PodSpec “image” property to initialize imageRegistryCredential property(when imagePullSecrets is not passed)

Validation

MI to authenticate image pull
image

image

Reference:

Deploy to ACR from ACR using MI: Deploy container image from Azure Container Registry using a managed identity - Azure Container Instances | Microsoft Docs
Attach ACR to AKS : Integrate Azure Container Registry with Azure Kubernetes Service - Azure Kubernetes Service | Microsoft Docs
MI with ACI: Enable managed identity in container group - Azure Container Instances | Microsoft Docs

@fnuarnav fnuarnav temporarily deployed to test August 24, 2023 20:14 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test September 1, 2023 01:16 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test September 1, 2023 01:20 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test September 1, 2023 01:21 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test September 1, 2023 02:34 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test September 1, 2023 02:34 — with GitHub Actions Inactive
Makefile Outdated Show resolved Hide resolved
@fnuarnav fnuarnav temporarily deployed to test October 5, 2023 23:00 — with GitHub Actions Inactive
@fnuarnav fnuarnav temporarily deployed to test October 6, 2023 17:53 — with GitHub Actions Inactive
@helayoty helayoty requested a review from smritidahal653 as a code owner July 6, 2024 01:39
@PSanetra
Copy link

@helayoty Is there any chance of getting this or a similar PR, which introduces managed identity support for pulling from ACRs, merged?

@Fei-Guo
Copy link
Collaborator

Fei-Guo commented Sep 12, 2024

@helayoty Is there any chance of getting this or a similar PR, which introduces managed identity support for pulling from ACRs, merged?

Hi, Philip, we are very close to release Virtual Kubelet version 2 in AKS, which has resolved this problem. I don't think we will actively add new features to this repo anymore. VN2 has not been open sourced yet and it uses a completely different architecture in which a real kubelet is involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants