feat: Managed Identity support for Image Pull #240
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| package e2e | ||
|
|
||
| import ( | ||
| "testing" | ||
| "time" | ||
| "context" | ||
|
|
||
| "github.com/virtual-kubelet/azure-aci/pkg/featureflag" | ||
| ) | ||
|
|
||
| func TestImagePullUsingKubeletIdentityMI(t *testing.T) { | ||
| ctx := context.TODO() | ||
| enabledFeatures := featureflag.InitFeatureFlag(ctx) | ||
| if !enabledFeatures.IsEnabled(ctx, featureflag.ManagedIdentityPullFeature) { | ||
| t.Skipf("%s feature is not enabled", featureflag.ManagedIdentityPullFeature) | ||
| } | ||
| // delete the pod first | ||
| cmd := kubectl("delete", "namespace", "vk-test", "--ignore-not-found") | ||
| if out, err := cmd.CombinedOutput(); err != nil { | ||
| t.Fatal(string(out)) | ||
| } | ||
|
|
||
| // create namespace | ||
| cmd = kubectl("apply", "-f", "fixtures/namespace.yml") | ||
| if out, err := cmd.CombinedOutput(); err != nil { | ||
| t.Fatal(string(out)) | ||
| } | ||
|
|
||
| // run container group pulling image from acr using MI | ||
| cmd = kubectl("apply", "-f", "fixtures/mi-pull-image-exec.yaml") | ||
| if out, err := cmd.CombinedOutput(); err != nil { | ||
| t.Fatal(string(out)) | ||
| } | ||
|
|
||
| deadline, ok := t.Deadline() | ||
| timeout := time.Until(deadline) | ||
| if !ok { | ||
| timeout = 300 * time.Second | ||
| } | ||
| cmd = kubectl("wait", "--for=condition=ready", "--timeout="+timeout.String(), "pod/e2etest-acr-test-mi-container", "--namespace=vk-test") | ||
| if out, err := cmd.CombinedOutput(); err != nil { | ||
| t.Fatal(string(out)) | ||
| } | ||
| t.Log("success pulling image from ACR using managed identity") | ||
|
|
||
| // query metrics | ||
| deadline = time.Now().Add(5 * time.Minute) | ||
| for { | ||
| t.Log("query metrics ....") | ||
| cmd = kubectl("get", "--raw", "/apis/metrics.k8s.io/v1beta1/namespaces/vk-test/pods/e2etest-acr-test-mi-container") | ||
| out, err := cmd.CombinedOutput() | ||
| if time.Now().After(deadline) { | ||
| t.Fatal("failed to query pod's stats from metrics server API") | ||
| } | ||
| if err == nil { | ||
| t.Logf("success query metrics %s", string(out)) | ||
| break | ||
| } | ||
| } | ||
|
|
||
| // check pod status | ||
| t.Log("get pod status ....") | ||
| cmd = kubectl("get", "pod", "--field-selector=status.phase=Running", "--namespace=vk-test", "--output=jsonpath={.items..metadata.name}") | ||
| out, err := cmd.CombinedOutput() | ||
| if err != nil { | ||
| t.Fatal(string(out)) | ||
| } | ||
| if string(out) != "e2etest-acr-test-mi-container" { | ||
| t.Fatal("failed to get pod's status") | ||
| } | ||
| t.Logf("success query pod status %s", string(out)) | ||
|
|
||
| // check container status | ||
| t.Log("get container status ....") | ||
| cmd = kubectl("get", "pod", "e2etest-acr-test-mi-container", "--namespace=vk-test", "--output=jsonpath={.status.containerStatuses[0].ready}") | ||
| out, err = cmd.CombinedOutput() | ||
| if err != nil { | ||
| t.Fatal(string(out)) | ||
| } | ||
| if string(out) != "true" { | ||
| t.Fatal("failed to get pod's status") | ||
| } | ||
| t.Logf("success query container status %s", string(out)) | ||
|
|
||
| t.Log("clean up pod") | ||
| cmd = kubectl("delete", "namespace", "vk-test", "--ignore-not-found") | ||
| if out, err := cmd.CombinedOutput(); err != nil { | ||
| t.Fatal(string(out)) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| apiVersion: v1 | ||
| kind: Pod | ||
| metadata: | ||
| name: e2etest-acr-test-mi-container | ||
| namespace: vk-test | ||
| spec: | ||
| restartPolicy: Never | ||
| containers: | ||
| - image: ${ACR_NAME}.azurecr.io/library/alpine | ||
| imagePullPolicy: Always | ||
| name: e2etest-acr-test-mi-container | ||
| command: [ | ||
| "sh", | ||
| "-c", | ||
| "sleep 1; while sleep 1; do echo pulled image using mi; done", | ||
| ] | ||
| resources: | ||
| requests: | ||
| memory: 1G | ||
| cpu: 1 | ||
| nodeSelector: | ||
| kubernetes.io/role: agent | ||
| beta.kubernetes.io/os: linux | ||
| type: virtual-kubelet | ||
| tolerations: | ||
| - key: virtual-kubelet.io/provider | ||
| operator: Exists |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please follow the same as the upgrade, etc docs? by creating a new file in the /docs folder and referring to it in this main one?