Distributed Transaction Resolver

[harshit-gangal]

Description

This PR changes VTGate to watch on transaction unresolved signal from the health stream. When received it invokes transaction resolution for that keyspace:shard. The transaction resolver retrieves the unresolved transaction list and resolves those transactions based on the current state i.e. commit/rollback/prepare.

Related Issue(s)

• RFC: Atomic Distributed Transactions #16245

Checklist

• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

Attention: Patch coverage is 32.52033% with 83 lines in your changes missing coverage. Please review.

Project coverage is 68.67%. Comparing base (c9c0aa5) to head (d50313a).
Report is 12 commits behind head on main.

Files	Patch %	Lines
go/vt/vtgate/txresolver/tx_resolver.go	0.00%	42 Missing ⚠️
go/vt/vtgate/tx_conn.go	46.47%	38 Missing ⚠️
go/vt/vtgate/vtgate.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16381      +/-   ##
==========================================
+ Coverage   68.66%   68.67%   +0.01%     
==========================================
  Files        1548     1549       +1     
  Lines      199071   199205     +134     
==========================================
+ Hits       136683   136796     +113     
- Misses      62388    62409      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[GuptaManan100]

LGTM!

[systay]

I'm confused. Isn't this test code? What is it doing here?

[harshit-gangal]

We will add the go build logic to include test and non-test functions. There is already a task to make the changes on the commit flow. That will be added as part of the PR.

[GuptaManan100]

Done! In the latest commits! 🚀