Add e2e tests for our VSHN services #267

TheBigLee · 2023-11-30T15:15:55Z

Checklist

The PR has a meaningful title. It will be used to auto generate the
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
PR contains a single logical change (to build a better changelog).
Categorize the PR by adding one of the labels:
bug, enhancement, documentation, change, breaking, dependency
as they show up in the changelog.
Link this PR to related issues or PRs.

Kidswiss

There seems to be a kuttl test with wrong identations.

tests/e2e/postgresql/00-assert.yaml

Signed-off-by: Nicolas Bigler <[email protected]>

fixed already

Kidswiss

Some things to adjust.

Kidswiss · 2024-03-14T13:34:42Z

component/component/vshn_postgres.jsonnet

@@ -424,6 +424,12 @@ local sgCluster = {
                  },
                  postgres: {
                    version: '',
+                    extensions: [


Please remove this, there's already a fix for this in the composition functions.

deleted that section

Kidswiss · 2024-03-14T13:56:29Z

tests/e2e/kuttl-test.yaml

+kind: TestSuite
+testDirs:
+  - ./test/e2e/
+namespace: widera-testing


we probably want a more generic name here.

Like vshn-appcat-e2e-tests

updated that section

tests/tests.mk

Kidswiss · 2024-03-14T14:04:38Z

tests/e2e/keycloak/01-connect.yaml

+      restartPolicy: Never
+      containers:
+        - name: connect
+          image: docker.io/appuio/oc:v4.14


This image does not work on Macs with Apple silicon: no match for platform in manifest: not found. Not sure why though, as other x86 images usually work with no problem.

However, as you only need curl, maybe some other image would be better suited here? Maybe some small alpine image with curl installed.

Agree here. I also use a mac and a lighter image is welcomed.

switched to another image also mentioned issue with that image on our #appuio-cloud RC channel

zugao

Some small things, rest is good.

zugao · 2024-03-15T10:17:43Z

component/class/defaults.yml

@@ -6,7 +6,7 @@ parameters:
        version: 17.7.1
      mariadb:
        source: https://charts.bitnami.com/bitnami
-        version: 10.1.3
+        version: 11.6.2


Why do we update the chart version in an e2e PR?

because e2e tests found an issue in old charts :D

zugao · 2024-03-15T10:19:35Z

tests/e2e/keycloak/01-connect.yaml

+      restartPolicy: Never
+      containers:
+        - name: connect
+          image: docker.io/appuio/oc:v4.14


Agree here. I also use a mac and a lighter image is welcomed.

tests/e2e/keycloak/01-connect.yaml

wejdross · 2024-03-15T15:30:59Z

@Kidswiss @zugao I just added new directory and file .githooks/pre-commit - it's small and simple python script to prevent user from commiting code when keycloak docker registry credentials are present in code, it's copied into .git/hooks directory whenever someone start compilation of golden files. Unfortunately this is the best protection we can apply because git doesn't like setting such script automatically

Kidswiss

LGTM

zugao

LGTM

already accepted

TheBigLee added the enhancement New feature or request label Nov 30, 2023

TheBigLee changed the base branch from master to feature/mariadb November 30, 2023 15:16

TheBigLee force-pushed the feature/mariadb branch from d3a107f to d2fc989 Compare November 30, 2023 15:16

TheBigLee mentioned this pull request Nov 30, 2023

Add composition for MariaDB service #263

Merged

4 tasks

TheBigLee force-pushed the feature/mariadb branch from d2fc989 to 8dfb658 Compare November 30, 2023 15:19

TheBigLee closed this Nov 30, 2023

TheBigLee force-pushed the feature/e2e_tests branch from 347a53b to 8dfb658 Compare November 30, 2023 15:26

TheBigLee reopened this Nov 30, 2023

TheBigLee force-pushed the feature/mariadb branch from 8dfb658 to d5e529a Compare November 30, 2023 15:32

TheBigLee force-pushed the feature/e2e_tests branch 2 times, most recently from 2f2adbe to 07b4bff Compare December 3, 2023 15:54

TheBigLee marked this pull request as ready for review December 3, 2023 15:56

TheBigLee force-pushed the feature/e2e_tests branch from 07b4bff to 963b5da Compare December 3, 2023 15:59

TheBigLee marked this pull request as draft December 3, 2023 15:59

TheBigLee force-pushed the feature/mariadb branch 3 times, most recently from 4a9efd9 to 4416f34 Compare December 5, 2023 10:01

Base automatically changed from feature/mariadb to master December 5, 2023 10:04

TheBigLee force-pushed the feature/e2e_tests branch from 963b5da to 95de839 Compare December 5, 2023 10:10

TheBigLee marked this pull request as ready for review December 5, 2023 10:23

TheBigLee requested review from zugao and Kidswiss December 5, 2023 10:24

TheBigLee force-pushed the feature/e2e_tests branch 3 times, most recently from 5768d2d to d278800 Compare December 5, 2023 15:06

Kidswiss previously requested changes Dec 6, 2023

View reviewed changes

tests/e2e/postgresql/00-assert.yaml Outdated Show resolved Hide resolved

wejdross force-pushed the feature/e2e_tests branch from d278800 to a098a24 Compare February 29, 2024 08:36

wejdross force-pushed the feature/e2e_tests branch 3 times, most recently from bfda383 to d216fce Compare March 13, 2024 08:39

wejdross force-pushed the feature/e2e_tests branch 2 times, most recently from c351a0d to c10989a Compare March 13, 2024 08:41

Add e2e smoke test for MariaDB

822ed98

Signed-off-by: Nicolas Bigler <[email protected]>

wejdross force-pushed the feature/e2e_tests branch from c10989a to 822ed98 Compare March 13, 2024 08:48

TheBigLee and others added 2 commits March 13, 2024 09:50

keycloak tests

c4f4b2e

making linter happy

c1ec674

wejdross requested a review from Kidswiss March 13, 2024 08:54

Kidswiss requested changes Mar 14, 2024

View reviewed changes

zugao previously requested changes Mar 15, 2024

View reviewed changes

wejdross self-assigned this Mar 15, 2024

apply PR suggestions

e262a16

wejdross force-pushed the feature/e2e_tests branch from aa6e4a9 to b4edd76 Compare March 15, 2024 15:21

add GIT hook and Makefile target

d47cce7

wejdross force-pushed the feature/e2e_tests branch from b4edd76 to d47cce7 Compare March 15, 2024 15:22

Kidswiss approved these changes Mar 18, 2024

View reviewed changes

wejdross requested a review from zugao March 18, 2024 08:07

wejdross approved these changes Mar 18, 2024

View reviewed changes

zugao reviewed Mar 18, 2024

View reviewed changes

wejdross merged commit e1d28e6 into master Mar 18, 2024
30 checks passed

wejdross deleted the feature/e2e_tests branch March 18, 2024 09:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add e2e tests for our VSHN services #267

Add e2e tests for our VSHN services #267

TheBigLee commented Nov 30, 2023

Kidswiss left a comment

Kidswiss left a comment

Kidswiss Mar 14, 2024

wejdross Mar 15, 2024

Kidswiss Mar 14, 2024

wejdross Mar 15, 2024

Kidswiss Mar 14, 2024

zugao Mar 15, 2024

wejdross Mar 15, 2024

zugao left a comment

zugao Mar 15, 2024

wejdross Mar 15, 2024

zugao Mar 15, 2024

wejdross commented Mar 15, 2024

Kidswiss left a comment

zugao left a comment

Add e2e tests for our VSHN services #267

Add e2e tests for our VSHN services #267

Conversation

TheBigLee commented Nov 30, 2023

Checklist

Kidswiss left a comment

Choose a reason for hiding this comment

Kidswiss left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zugao left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wejdross commented Mar 15, 2024

Kidswiss left a comment

Choose a reason for hiding this comment

zugao left a comment

Choose a reason for hiding this comment