configd: T6608: report uncaught config script exceptions as commit error

[jestabro]

Change Summary

Exceptions uncaught by config scripts should be caught by configd and returned as commit error. The previous behavior of configd was to catch and report as a daemon error to the shim, allowing for the possibility of a pass-through execution (as with any other daemon originating error). The introduction of config dependencies, however, requires the return of a commit error.

The error output returns the traceback, consistent with the output running without configd; simple test case below for comparison:

with configd:

vyos@vyos# commit
[ simple some-tag-node some0 ]
Traceback (most recent call last):
  File "/usr/libexec/vyos/services/vyos-configd", line 134, in run_script
    script.verify(c)
  File "/usr/libexec/vyos//conf_mode/simple.py", line 50, in verify
    raise OSError('This is an uncaught exception')
OSError: This is an uncaught exception

[[simple some-tag-node some0]] failed
Commit failed

without configd:

vyos@vyos# set simple some-tag-node some0
[edit]
vyos@vyos# commit
[ simple some-tag-node some0 ]
Traceback (most recent call last):
  File "/usr/libexec/vyos/conf_mode/simple.py", line 64, in <module>
    verify(c)
  File "/usr/libexec/vyos/conf_mode/simple.py", line 50, in verify
    raise OSError('This is an uncaught exception')
OSError: This is an uncaught exception

[[simple some-tag-node some0]] failed
Commit failed

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[github-actions]

👍
No issues in PR Title / Commit Title

[github-actions]

✅ No issues found in unused-imports check.. Please refer the workflow run

[github-actions]

CI integration 👍 passed!

Details

CI logs

• CLI Smoketests 👍 passed
• Config tests 👍 passed
• RAID1 tests 👍 passed

[jestabro]

This PR will be split into separate submissions for (1) those bugs obscured by the design choice described in T6608, and (2) the actual change in behavior (this PR) from pass-through to error on exceptions uncaught by config mode scripts. This PR will be moved from draft after the two or three instances in (1) are merged.

[jestabro]

This will be moved out of draft following
#3955
#3937
and resolution of T6638, which manifests in configtest vrf-bgp-pppoe-underlay

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.