Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Conformance classes #231

Merged
merged 11 commits into from
Feb 20, 2024
Merged

Add Conformance classes #231

merged 11 commits into from
Feb 20, 2024

Conversation

brentzundel
Copy link
Member

@brentzundel brentzundel commented Feb 13, 2024 •
edited by pr-preview bot
Loading

This PR attempts to fix #202 and fix #192

I am confident it will need adjustment after review and feedback.

Preview | Diff

@brentzundel
Add Conformance classes
45d2ebf 
Signed-off-by: Brent Zundel <[email protected]>
@brentzundel
fix conforming CWT verifier
8bc1b9b 
Signed-off-by: Brent Zundel <[email protected]>
@brentzundel
fix COSE->CWT
bc6f2d9 
Signed-off-by: Brent Zundel <[email protected]>
@brentzundel
remove extra quote
776c486 
Signed-off-by: Brent Zundel <[email protected]>
@brentzundel
remove extra quote
489f2b5 
Signed-off-by: Brent Zundel <[email protected]>
@brentzundel
move conforming verifier to securing sections
6e6e696 
Signed-off-by: Brent Zundel <[email protected]>
@brentzundel
Copy link
Member Author

I'm not sure what is causing the build error. @iherman any thoughts?

decentralgabe
decentralgabe approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent!

selfissued
selfissued reviewed Feb 13, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
selfissued
selfissued reviewed Feb 13, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
selfissued
selfissued reviewed Feb 13, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
selfissued
selfissued reviewed Feb 13, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
selfissued
selfissued approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, after merging my suggestions.

selfissued
selfissued reviewed Feb 13, 2024
View reviewed changes
index.html Outdated Show resolved Hide resolved
brentzundel and others added 4 commits February 14, 2024 09:03
@brentzundel
Copy link
Member Author

@decentralgabe @selfissued I found the error!
I was adding a new conformance section, when it turns out there already was one. I added my new content to the existing section and now there are no build errors.
Let me know if you see any other needed changes.

@brentzundel brentzundel mentioned this pull request Feb 15, 2024
Closed
@decentralgabe decentralgabe merged commit 6874bf8 into w3c:main Feb 20, 2024
2 checks passed
@brentzundel brentzundel mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selfissued selfissued selfissued approved these changes

@decentralgabe decentralgabe decentralgabe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conformance classes are not defined Spec should be more specific about implementation details
3 participants
@brentzundel @decentralgabe @selfissued