Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Securing with JWS #239

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Add Securing with JWS #239

merged 3 commits into from
Feb 26, 2024

Conversation

selfissued
Copy link
Collaborator

@selfissued selfissued commented Feb 20, 2024

Fixes #201


Preview | Diff

index.html Outdated Show resolved Hide resolved
@iherman
Copy link
Member

iherman commented Feb 20, 2024

I may misunderstand something. But... on the examples 2 and 4, on the tab 'Verified', I miss the id value for the protected and enveloped verifiable credential. This id value, which is a data URL, should encode the credential itself. Compare to Example in the VCDM spec.

@iherman
Copy link
Member

iherman commented Feb 20, 2024

I think this was already mentioned elsewhere (@decentralgabe may remember): in Example 26 the list for verifiableCredential is erroneous. "Pure" URL-s may not appear there...

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@decentralgabe
Copy link
Collaborator

@iherman I see what you're saying, there is an issue with our example rendering. @OR13 has graciously taken on some work to fix this, for which I have opened #240 to track this and referenced your issue.

I would ask that we view Mike's change set independent of the example rendering issues, which I will work to fix in the coming days.

@brentzundel
Copy link
Member

I'm not sure I'll be a helpful reviewer until this PR is rebased on top of recent changes made in #231

@decentralgabe decentralgabe merged commit 921beb0 into w3c:main Feb 26, 2024
2 checks passed
COSE supports two main operations: signing and encryption. For
signing, COSE allows the creation of digital signatures over
CBOR data using various algorithms such as HMAC, RSA, ECDSA, or
CBOR data using various algorithms such as RSA, ECDSA, and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
CBOR data using various algorithms such as RSA, ECDSA, and
CBOR data using various algorithms including RSA, ECDSA, and

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support JWT-secured VCs
6 participants