-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Securing with JWS #239
Conversation
I may misunderstand something. But... on the examples 2 and 4, on the tab 'Verified', I miss the id value for the protected and enveloped verifiable credential. This id value, which is a data URL, should encode the credential itself. Compare to Example in the VCDM spec. |
I think this was already mentioned elsewhere (@decentralgabe may remember): in Example 26 the list for |
@iherman I see what you're saying, there is an issue with our example rendering. @OR13 has graciously taken on some work to fix this, for which I have opened #240 to track this and referenced your issue. I would ask that we view Mike's change set independent of the example rendering issues, which I will work to fix in the coming days. |
I'm not sure I'll be a helpful reviewer until this PR is rebased on top of recent changes made in #231 |
COSE supports two main operations: signing and encryption. For | ||
signing, COSE allows the creation of digital signatures over | ||
CBOR data using various algorithms such as HMAC, RSA, ECDSA, or | ||
CBOR data using various algorithms such as RSA, ECDSA, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CBOR data using various algorithms such as RSA, ECDSA, and | |
CBOR data using various algorithms including RSA, ECDSA, and |
Fixes #201
Preview | Diff