Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin to pull in COSE, JWT, and SD-JWT rendering #241

Merged
merged 15 commits into from
Feb 26, 2024
Merged

Conversation

decentralgabe
Copy link
Collaborator

@decentralgabe decentralgabe commented Feb 21, 2024

Copy link
Collaborator

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this

@decentralgabe
Copy link
Collaborator Author

the plugin is working but currently combines COSE, JOSE, and SD-JWT in all tabs. If are OK with that it can be merged soon, which may be a reasonable first step.

if not, I can break out the examples into a few possibilities:

  1. All three together (COSE, JOSE, SD-JWT)
  2. All three individually
  3. ??? whatever we need

@decentralgabe decentralgabe linked an issue Feb 21, 2024 that may be closed by this pull request
plugin/README.md Outdated Show resolved Hide resolved
@decentralgabe decentralgabe marked this pull request as ready for review February 22, 2024 17:32
@decentralgabe
Copy link
Collaborator Author

The change set now incorporates the latest update to the rendering plugin, which allows us to separately render JWT, SD-JWT, and COSE examples.

I've added examples for all three in their respective sections. After #239 is merged this will need to be updated to split out the SD-JWT and JWT examples into their respective sections.

plugin/README.md Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@decentralgabe
Copy link
Collaborator Author

rebased and updated examples per each section. merging.

@decentralgabe decentralgabe merged commit 5bbe9f2 into main Feb 26, 2024
1 of 2 checks passed
@decentralgabe decentralgabe deleted the issue-240 branch February 26, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update example rendering for JOSE / COSE
4 participants