Modified unit test for differences #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thub hash sources.
|
Thanks @cmirzayi. Can you modify the PR by adding an argument |
|
I expedited the incorporation of the PR in 5b35f87 given the upcoming new release. Thanks for the input @cmirzayi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current unit test for
importBugSigDB()checks for a data.frame with at least 2000 rows. Since there is now a large difference between the devel version (~5,700 rows), Zenodo version (~3,500 rows), and Github hash (~2,200) rows), I created separate versions ofcheckImport()for these various versions.This is in part to detect issues in the size of the export from BugSigDB which has been a recurring issue as of late.