Fixedwidth during stream of CF events #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simcap
reviewed
Apr 9, 2018
| // Format reads the struct tag `width:"<width>,<space>"` | ||
| // further marshaling into structured field | ||
| func (s *stackEvent) format(fil filters) []byte { | ||
| tp := reflect.TypeOf(s).Elem() |
There was a problem hiding this comment.
Do you think it would be possible to add table unit tests for that method which seems central? It would help the understanding, document a bit the look of the output, put non regression in place and allow future safe refactoring.
I do not have the answer, I am just wondering.
|
Tailers are experimental and are not advertised on the sub commands listing, so we have more leeway in their implementation. So we shall review that and it could make it into the 0.1.10 that is due in the next 2 days. Otherwise thanks for the work @trane9991 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the custom solution for streaming CloudFormation events into a structured table with a column of fixed width, to prevent "jumping"
Before:
After:
The new approach uses Reflection and pretty complex but seems to work well.