Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement embeddable dashboard on Docker module #6526

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Mar 15, 2024

Description

This pull request replaces the Dashboard tab on Docker application.

Issues Resolved

Evidence

image

Test

Global

Test Chrome Firefox Safari
Check data results consistency between events and dashboard tab
Check the filters persist between the events and dashboard tab
Check the filters are cleaned when throwing in the events tab
Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs)
Check pinned agent filter on tabs
Check the request with hidden filters applied (allow agents, hide manager alerts)
Check the fixer filter cannot be removed from the filter bar (the remove icon is hidden)
  • Check data results consistency between events and dashboard tab
  • Check the filters persist between the events and dashboard tab
  • Check the filters are cleaned when throwing in the events tab
  • Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs)
  • Check pinned agent filter on tabs
  • Check the request with hidden filters applied (allow agents, hide manager alerts)

Enable/disable the hideManagerAlerts settings on App Settings

Screenshot 2024-03-31 at 12 29 47
  • Check the fixed filter cannot be removed from the filter bar

Dashboard tab

Test Chrome Firefox Safari
Use search bar input to filter any word and check if the dashboard shows the corresponding results
Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter
Add a filter through interaction with a visualization and check that the dashboard updates
Use the input and type an incorrect word to check if the no results message is shown
  • Use search bar input to filter any word and check if the dashboard shows the corresponding results
  • Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter
  • Add a filter through interaction with a visualization and check that the dashboard updates
  • Use the input and type an incorrect word to check if the no results message is shown

Events tab (Discover)

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input
Apply filters using the search bar add filter feature
Apply filters using the date picker
Apply filters with no results (Check the No results match your search criteria message)
Use the saved queries feature (Check saved queries CRUD)
  • Apply filters using search bar input
  • Apply filters using the search bar add filter feature
  • Apply filters using the date picker
  • Apply filters with no results (Check the No results match your search criteria message)
  • Use the saved queries feature (Check saved queries CRUD)

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency
Use chart options (three points: maximize, minimize, inspect)
  • Check histogram chart hits consistency
  • Use chart options (three points: maximize, minimize, inspect)

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc)
Check table pagination and rows per page
Check document detail flyout
  • Check all table header features (sort, show/hide columns, density, etc)
  • Check table pagination and rows per page
  • Check document detail flyout

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Mar 15, 2024
@asteriscos asteriscos linked an issue Mar 15, 2024 that may be closed by this pull request
15 tasks
@asteriscos asteriscos marked this pull request as ready for review April 16, 2024 18:34
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.37% ( 397 / 875 )
Branches 41.31% ( 157 / 380 )
Functions 43.83% ( 135 / 308 )
Lines 45.61% ( 395 / 866 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 10.81% ( 3753 / 34712 )
Branches 7.27% ( 1653 / 22731 )
Functions 10.5% ( 870 / 8279 )
Lines 10.96% ( 3647 / 33269 )

@yenienserrano
Copy link
Member

yenienserrano commented Apr 24, 2024

Test

Global

Test Chrome Firefox Safari
Check data results consistency between events and dashboard tab 🟢
Check the filters persist between the events and dashboard tab 🟢
Check the filters are cleaned when throwing in the events tab 🟢
Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs) 🟢
Check pinned agent filter on tabs 🟢
Check the request with hidden filters applied (allow agents, hide manager alerts) 🟢
Check the fixer filter cannot be removed from the filter bar (the remove icon is hidden) 🔴
  • 🟢 Check data results consistency between events and dashboard tab
image image
  • 🟢 Check the filters persist between the events and dashboard tab
image image
  • 🟢 Check the filters are cleaned when throwing in the events tab
image image
  • 🟢 Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs)
image image
  • 🟢 Check pinned agent filter on tabs
image image
  • 🟢 Check the request with hidden filters applied (allow agents, hide manager alerts)

Enable/disable the hideManagerAlerts settings on App Settings

Screenshot 2024-03-31 at 12 29 47 image image
  • 🔴 Check the fixed filter cannot be removed from the filter bar
In this PR we add a class to hide the button that allows to remove the global filters. https://github.com//pull/6482 image image image

Dashboard tab

Test Chrome Firefox Safari
Use search bar input to filter any word and check if the dashboard shows the corresponding results 🟢
Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter 🟢
Add a filter through interaction with a visualization and check that the dashboard updates 🟢
Use the input and type an incorrect word to check if the no results message is shown 🟢
  • 🟢 Use search bar input to filter any word and check if the dashboard shows the corresponding results
image
  • 🟢 Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter
image
  • 🟢 Add a filter through interaction with a visualization and check that the dashboard updates
image image
  • 🟢 Use the input and type an incorrect word to check if the no results message is shown
image

Events tab (Discover)

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD)
  • 🟢 Apply filters using search bar input
image
  • 🟢 Apply filters using the search bar add filter feature
image
  • 🟢 Apply filters using the date picker
image
  • 🟢 Apply filters with no results (Check the No results match your search criteria message)
image
  • Use the saved queries feature (Check saved queries CRUD)

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
  • 🟢 Check histogram chart hits consistency
image
  • 🟢 Use chart options (three points: maximize, minimize, inspect)
image image

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
  • 🟢 Check all table header features (sort, show/hide columns, density, etc)
image image image image
  • 🟢 Check table pagination and rows per page
image
  • 🟢 Check document detail flyout
image

yenienserrano
yenienserrano previously approved these changes Apr 25, 2024
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JuanGarriuz
Copy link
Member

JuanGarriuz commented Apr 30, 2024

Test

Global

Test Chrome Firefox Safari
Check data results consistency between events and dashboard tab 🟢
Check the filters persist between the events and dashboard tab 🟢
Check the filters are cleaned when throwing in the events tab 🟢
Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs) 🟢
Check pinned agent filter on tabs 🟢
Check the request with hidden filters applied (allow agents, hide manager alerts) 🟢
Check the fixer filter cannot be removed from the filter bar (the remove icon is hidden) 🟢
  • Check data results consistency between events and the dashboard tab

image
image

  • Check the filters persist between the events and dashboard tab

image
image

  • Check the filters are cleaned when throwing in the events tab

image
image

  • Check cluster-manager filter on tabs. Must be applied when the tab is shown (all tabs)

image
image

  • Check pinned agent filter on tabs

image
image

  • Check the request with hidden filters applied (allow agents, hide manager alerts)

image

  • Check the fixed filter cannot be removed from the filter bar

image

Dashboard tab

Test Chrome Firefox Safari
Use search bar input to filter any word and check if the dashboard shows the corresponding results 🟢
Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter 🟢
Add a filter through interaction with a visualization and check that the dashboard updates 🟢
Use the input and type an incorrect word to check if the no results message is shown 🟢
  • Use search bar input to filter any word and check if the dashboard shows the corresponding results

image

  • Select an option from one of the recommended filters and check that the corresponding filter is added and the dashboard changes according to the applied filter

image

  • Add a filter through interaction with a visualization and check that the dashboard updates
Grabacion.2024-04-30.110838.mp4
  • Use the input and type an incorrect word to check if the no results message is shown

image

Events tab (Discover)

Search bar

Test Chrome Firefox Safari
Apply filters using search bar input 🟢
Apply filters using the search bar add filter feature 🟢
Apply filters using the date picker 🟢
Apply filters with no results (Check the No results match your search criteria message) 🟢
Use the saved queries feature (Check saved queries CRUD) 🟢
  • Apply filters using search bar input

image

  • Apply filters using the search bar add filter feature

image

  • Apply filters using the date picker

image
image

  • Apply filters with no results (Check the No results match your search criteria message)

image

  • Use the saved queries feature (Check saved queries CRUD)

image

Histogram chart

Test Chrome Firefox Safari
Check histogram chart hits consistency 🟢
Use chart options (three points: maximize, minimize, inspect) 🟢
  • Check histogram chart hits consistency

image

  • Use chart options (three points: maximize, minimize, inspect)
Grabacion.2024-04-30.110838.mp4

Data grid

Test Chrome Firefox Safari
Check all table header features (sort, show/hide columns, density, etc) 🟢
Check table pagination and rows per page 🟢
Check document detail flyout 🟢
  • Check all table header features (sort, show/hide columns, density, etc)
Grabacion.2024-04-30.110838.mp4
  • Check table pagination and rows per page
Grabacion.2024-04-30.110838.mp4
  • Check document detail flyout
Grabacion.2024-04-30.110838.mp4

JuanGarriuz
JuanGarriuz previously approved these changes Apr 30, 2024
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@asteriscos asteriscos merged commit c5bdf90 into 4.9.0 May 3, 2024
1 check passed
@asteriscos asteriscos deleted the 6500-remove-discover-implement-embeddable-dashboard-on-docker-module branch May 3, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remove discover] Implement embeddable dashboard on Docker module
3 participants