-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement embeddable dashboard on Docker module #6526
Merged
asteriscos
merged 11 commits into
4.9.0
from
6500-remove-discover-implement-embeddable-dashboard-on-docker-module
May 3, 2024
Merged
Implement embeddable dashboard on Docker module #6526
asteriscos
merged 11 commits into
4.9.0
from
6500-remove-discover-implement-embeddable-dashboard-on-docker-module
May 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
…ashboard-on-docker-module
…ashboard-on-docker-module
|
|
|
…ashboard-on-docker-module
TestGlobal
In this PR we add a class to hide the button that allows to remove the global filters.
https://github.com//pull/6482
Dashboard tab
Events tab (Discover)Search bar
Histogram chart
Data grid
|
plugins/main/public/components/overview/docker/dashboards/dashboard.tsx
Outdated
Show resolved
Hide resolved
…ashboard-on-docker-module
…ashboard-on-docker-module
yenienserrano
previously approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ashboard-on-docker-module
TestGlobal
Dashboard tab
Grabacion.2024-04-30.110838.mp4
Events tab (Discover)Search bar
Histogram chart
Grabacion.2024-04-30.110838.mp4Data grid
Grabacion.2024-04-30.110838.mp4
Grabacion.2024-04-30.110838.mp4
Grabacion.2024-04-30.110838.mp4 |
JuanGarriuz
previously approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
…ashboard-on-docker-module
…ashboard-on-docker-module
JuanGarriuz
approved these changes
May 3, 2024
asteriscos
deleted the
6500-remove-discover-implement-embeddable-dashboard-on-docker-module
branch
May 3, 2024 10:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request replaces the
Dashboard
tab on Docker application.Issues Resolved
Evidence
Test
Global
Enable/disable the hideManagerAlerts settings on App Settings
Dashboard tab
Events tab (Discover)
Search bar
add filter
featureNo results match your search criteria
message)saved queries
feature (Check saved queries CRUD)add filter
featureNo results match your search criteria
message)saved queries
feature (Check saved queries CRUD)Histogram chart
Data grid
Check List
yarn test:jest