Remove author-provided <datalist> from <select> #47827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5801649
branch
from
25a1525
to
32b248f
Compare
The author-provided datalist imposes a lot of complexity, and now that we aren't requiring it for HTML parser changes, it doesn't provide any additional capabilities. This patch also makes the UA popover actually have the popover attribute and makes it a <div> instead of a <datalist>. No code or concepts have "datalist" in them anymore except ::select-fallback-datalist because that is likely to get a different standards-approved name soon. This was discussed here: openui/open-ui#1082 This patch also moves a bunch of tests from external/wpt to wpt_internal because we aren't allowed to use test_driver in reftests in external/wpt, and I was using datalist.showPicker() in a bunch of reftests which we can't do anymore because the popover is now a pseudo-element which can only be opened via select.showPicker() which requires user activation, and in order to get user activation, we have to run test_driver.bless(). Change-Id: Ib8230bc5eec214f09147ae806490df729f1e4412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5801649 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1348235}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5801649
branch
from
32b248f
to
cf2a37b
Compare
wpt-pr-bot
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The author-provided datalist imposes a lot of complexity, and now that
we aren't requiring it for HTML parser changes, it doesn't provide any
additional capabilities.
This patch also makes the UA popover actually have the popover attribute
and makes it a <div> instead of a <datalist>.
No code or concepts have "datalist" in them anymore except
::select-fallback-datalist because that is likely to get a different
standards-approved name soon.
This was discussed here: openui/open-ui#1082
This patch also moves a bunch of tests from external/wpt to wpt_internal
because we aren't allowed to use test_driver in reftests in
external/wpt, and I was using datalist.showPicker() in a bunch of
reftests which we can't do anymore because the popover is now a
pseudo-element which can only be opened via select.showPicker() which
requires user activation, and in order to get user activation, we have
to run test_driver.bless().
Change-Id: Ib8230bc5eec214f09147ae806490df729f1e4412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5801649
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1348235}