feat: SingleEditorMode #8984
Open
feat: SingleEditorMode #8984
+398
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…js-mode feat: Add config for non-yjs mode
|
feat: non-yjs mode badge
…omes-active-and-exceeds-the-threshold-switch-to-non-yjs-mode
|
reg-suit detected visual differences. Check this report, and review them. 🔴🔴 🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵 What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
yuki-takei
requested changes
Sep 3, 2024
| const shouldUpdateProps = (props != null && currentCmPropsData == null) || (props != null && currentCmPropsData != null && !isDeepEquals(currentCmPropsData, props)); | ||
|
|
||
| // eslint-disable-next-line max-len | ||
| const shouldUpdate = swrKey != null && container != null && (currentData == null || (isValid(newData) && !isDeepEquals(currentData, newData)) || shouldUpdateProps); |
There was a problem hiding this comment.
shouldUpdate ロジック、テスト書かないとデグレ起こった時に直すのが大変そう
これは後続タスクで構わないのでやってほしい
support: `@uiw/react-codemirror` in apps/app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redmine.weseek.co.jp/issues/142089 のトピックブランチ