[WFCORE-7094] Fix remaining incorrect calls to ModuleIdentifier.getNa… #6281

bstansberry · 2024-12-14T22:04:55Z

…me() from WFCORE-6871

https://issues.redhat.com/browse/WFCORE-7094

…me() from WFCORE-6871

wildfly-ci · 2024-12-15T02:45:21Z

Core -> Full Integration Build 14423 outcome was FAILURE using a merge of cf98626
Summary: Tests failed: 1 (1 new), passed: 7978, ignored: 113 Build time: 04:40:14

Failed tests

TestSuite: org.eclipse.microprofile.rest.client.tck.sse.ReactiveStreamsPublisherTckTest.stochastic_spec103_mustSignalOnMethodsSequentially: java.lang.NullPointerException: Cannot invoke "org.reactivestreams.Publisher.subscribe(org.reactivestreams.Subscriber)" because "pub" is null
	at org.reactivestreams.tck.PublisherVerification$5$1.run(PublisherVerification.java:257)
	at org.reactivestreams.tck.PublisherVerification.activePublisherTest(PublisherVerification.java:1135)
	at org.reactivestreams.tck.PublisherVerification$5.apply(PublisherVerification.java:251)
	at org.reactivestreams.tck.PublisherVerification$5.apply(PublisherVerification.java:248)
	at org.reactivestreams.tck.PublisherVerification.stochasticTest(PublisherVerification.java:1204)
	at org.reactivestreams.tck.PublisherVerification.stochastic_spec103_mustSignalOnMethodsSequentially(PublisherVerification.java:248)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:141)
	at org.testng.internal.invokers.TestInvoker.invokeMethod(TestInvoker.java:686)
	at org.testng.internal.invokers.TestInvoker.invokeTestMethod(TestInvoker.java:230)
	at org.testng.internal.invokers.MethodRunner.runInSequence(MethodRunner.java:63)
	at org.testng.internal.invokers.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:992)
	at org.testng.internal.invokers.TestInvoker.invokeTestMethods(TestInvoker.java:203)
	at org.testng.internal.invokers.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:154)
	at org.testng.internal.invokers.TestMethodWorker.run(TestMethodWorker.java:134)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at org.testng.TestRunner.privateRun(TestRunner.java:739)
	at org.testng.TestRunner.run(TestRunner.java:614)
	at org.testng.SuiteRunner.runTest(SuiteRunner.java:421)
	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:413)
	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:373)
	at org.testng.SuiteRunner.run(SuiteRunner.java:312)
	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:95)
	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1274)
	at org.testng.TestNG.runSuitesLocally(TestNG.java:1208)
	at org.testng.TestNG.runSuites(TestNG.java:1112)
	at org.testng.TestNG.run(TestNG.java:1079)
------- Stderr: -------
java.lang.AssertionError: Mock Sse Server did not start as expected expected [true] but found [false]
	at org.testng.Assert.fail(Assert.java:111)
	at org.testng.Assert.failNotEquals(Assert.java:1578)
	at org.testng.Assert.assertTrue(Assert.java:57)
	at org.eclipse.microprofile.rest.client.tck.sse.AbstractSseTest.launchServer(AbstractSseTest.java:62)
	at org.eclipse.microprofile.rest.client.tck.sse.ReactiveStreamsPublisherTckTest.createPublisher(ReactiveStreamsPublisherTckTest.java:106)
	at org.reactivestreams.tck.PublisherVerification.activePublisherTest(PublisherVerification.java:1134)
	at org.reactivestreams.tck.PublisherVerification$5.apply(PublisherVerification.java:251)
	at org.reactivestreams.tck.PublisherVerification$5.apply(PublisherVerification.java:248)
	at org.reactivestreams.tck.PublisherVerification.stochasticTest(PublisherVerification.java:1204)
	at org.reactivestreams.tck.PublisherVerification.stochastic_spec103_mustSignalOnMethodsSequentially(PublisherVerification.java:248)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:141)
	at org.testng.internal.invokers.TestInvoker.invokeMethod(TestInvoker.java:686)
	at org.testng.internal.invokers.TestInvoker.invokeTestMethod(TestInvoker.java:230)
	at org.testng.internal.invokers.MethodRunner.runInSequence(MethodRunner.java:63)
	at org.testng.internal.invokers.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:992)

wildfly-ci · 2024-12-16T03:14:46Z

Core -> Full Integration Build 14425 outcome was FAILURE using a merge of cf98626
Summary: Tests failed: 1 (1 new), passed: 7978, ignored: 113 Build time: 05:01:28

Failed tests

org.wildfly.test.integration.microprofile.reactive.messaging.multiple.deployment.MultiDeploymentReactiveMessagingTestCase.testMultipleReactiveMessagingModules: java.lang.AssertionError: Timeout reading http://[::1]:8080/multideployment-rm-amqp
	at org.wildfly.test.integration.microprofile.reactive.messaging.multiple.deployment.MultiDeploymentReactiveMessagingTestCase.checkData(MultiDeploymentReactiveMessagingTestCase.java:217)
	at org.wildfly.test.integration.microprofile.reactive.messaging.multiple.deployment.MultiDeploymentReactiveMessagingTestCase.testMultipleReactiveMessagingModules(MultiDeploymentReactiveMessagingTestCase.java:162)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
------- Stdout: -------
 [0m01:47:16,870 INFO  [org.jboss.modules] (main) JBoss Modules version 2.1.6.Final
 [0m [0m01:47:17,453 INFO  [org.jboss.msc] (main) JBoss MSC version 1.5.5.Final
 [0m [0m01:47:17,462 INFO  [org.jboss.threads] (main) JBoss Threads version 2.4.0.Final
 [0m [0m01:47:17,596 INFO  [org.jboss.as] (MSC service thread 1-3) WFLYSRV0049: WildFly 35.0.0.Final-SNAPSHOT (WildFly Core 27.0.0.Beta6-SNAPSHOT) starting
 [0m [0m01:47:18,851 INFO  [org.wildfly.security] (Controller Boot Thread) ELY00001: WildFly Elytron version 2.6.0.Final
 [0m [0m01:47:19,834 INFO  [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0039: Creating http management service using socket-binding (management-http)
 [0m [0m01:47:19,856 INFO  [org.xnio] (MSC service thread 1-5) XNIO version 3.8.16.Final
 [0m [0m01:47:19,875 INFO  [org.xnio.nio] (MSC service thread 1-5) XNIO NIO Implementation Version 3.8.16.Final
 [0m [0m01:47:19,940 INFO  [org.jboss.as.connector.subsystems.datasources] (ServerService Thread Pool -- 39) WFLYJCA0004: Deploying JDBC-compliant driver class org.h2.Driver (version 2.2)
 [0m [0m01:47:19,978 INFO  [org.jboss.remoting] (MSC service thread 1-4) JBoss Remoting version 5.0.30.Final
 [0m [0m01:47:19,994 INFO  [org.wildfly.extension.elytron.oidc._private] (ServerService Thread Pool -- 45) WFLYOIDC0001: Activating WildFly Elytron OIDC Subsystem

yersan · 2024-12-17T10:05:50Z

This got a conflict I resolved directly in the PR

yersan · 2024-12-17T10:10:20Z

Thanks @bstansberry

wildfly-ci · 2024-12-17T12:14:57Z

Core -> Full Integration Build 14436 outcome was FAILURE using a merge of a3991b3
Summary: Error while applying patch Build time: 00:00:48

wildfly-ci · 2024-12-17T12:15:13Z

Core -> Full Integration Build 14135 outcome was FAILURE using a merge of a3991b3
Summary: Error while applying patch Build time: 00:00:16

wildfly-ci · 2024-12-17T12:15:45Z

Core -> WildFly Preview Integration Build 14217 outcome was FAILURE using a merge of a3991b3
Summary: Error while applying patch Build time: 00:00:16

[WFCORE-7094] Fix remaining incorrect calls to ModuleIdentifier.getNa…

cf98626

…me() from WFCORE-6871

bstansberry added Blocker 27.x labels Dec 14, 2024

This comment was marked as off-topic.

Sign in to view

bstansberry mentioned this pull request Dec 15, 2024

[WFCORE-7095] Deprecate ModuleDependency.getIdentifier() for removal; move partly away from MI in ServiceModuleLoader #6282

Open

This comment was marked as off-topic.

Sign in to view

yersan approved these changes Dec 17, 2024

View reviewed changes

yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Dec 17, 2024

Merge branch 'main' into WFCORE-7094

a3991b3

yersan merged commit ebf13df into wildfly:main Dec 17, 2024
2 of 5 checks passed

bstansberry deleted the WFCORE-7094 branch December 17, 2024 17:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WFCORE-7094] Fix remaining incorrect calls to ModuleIdentifier.getNa… #6281

[WFCORE-7094] Fix remaining incorrect calls to ModuleIdentifier.getNa… #6281

bstansberry commented Dec 14, 2024

This comment was marked as off-topic.

wildfly-ci commented Dec 15, 2024

This comment was marked as off-topic.

wildfly-ci commented Dec 16, 2024

yersan commented Dec 17, 2024

yersan commented Dec 17, 2024

wildfly-ci commented Dec 17, 2024

wildfly-ci commented Dec 17, 2024

wildfly-ci commented Dec 17, 2024

[WFCORE-7094] Fix remaining incorrect calls to ModuleIdentifier.getNa… #6281

[WFCORE-7094] Fix remaining incorrect calls to ModuleIdentifier.getNa… #6281

Conversation

bstansberry commented Dec 14, 2024

This comment was marked as off-topic.

wildfly-ci commented Dec 15, 2024

Failed tests

This comment was marked as off-topic.

wildfly-ci commented Dec 16, 2024

Failed tests

yersan commented Dec 17, 2024

yersan commented Dec 17, 2024

wildfly-ci commented Dec 17, 2024

wildfly-ci commented Dec 17, 2024

wildfly-ci commented Dec 17, 2024