Skip to content

Commit

Permalink
Add detail when failing to extract containers.
Browse files Browse the repository at this point in the history
  • Loading branch information
barnson committed Feb 29, 2024
1 parent b62127f commit 1a1da6f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/wix/WixToolset.Core.Burn/BurnBackendWarnings.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ public static Message EmptyContainer(SourceLineNumber sourceLineNumbers, string
return Message(sourceLineNumbers, Ids.EmptyContainer, "The Container '{0}' is being ignored because it doesn't have any payloads.", containerId);
}

public static Message FailedToExtractAttachedContainers(SourceLineNumber sourceLineNumbers)
public static Message FailedToExtractAttachedContainers(SourceLineNumber sourceLineNumbers, string message)
{
return Message(sourceLineNumbers, Ids.FailedToExtractAttachedContainers, "Failed to extract attached container. This most often happens when extracting a stripped bundle from the package cache, which is not supported.");
return Message(sourceLineNumbers, Ids.FailedToExtractAttachedContainers, "Failed to extract attached container. This most often happens when extracting a stripped bundle from the package cache, which is not supported. Detail: {0}", message);
}

public static Message HiddenBundleNotSupported(SourceLineNumber sourceLineNumbers, string packageId)
Expand Down
4 changes: 2 additions & 2 deletions src/wix/WixToolset.Core.Burn/CommandLine/ExtractSubcommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ public override Task<int> ExecuteAsync(CancellationToken cancellationToken)
reader.ExtractAttachedContainers(this.ExtractContainersPath, this.IntermediateFolder);
}
}
catch
catch (Exception e)
{
this.Messaging.Write(BurnBackendWarnings.FailedToExtractAttachedContainers(new SourceLineNumber(this.ExtractContainersPath)));
this.Messaging.Write(BurnBackendWarnings.FailedToExtractAttachedContainers(new SourceLineNumber(this.ExtractContainersPath), e.Message));
}
}
}
Expand Down

0 comments on commit 1a1da6f

Please sign in to comment.