Closes #7038 Activate minification by default

[Khadreal]

Description

Fixes #7038
Activate minification by default.

Type of change

• Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

Check EPIC Card

Technical description

Change the value of minify_css/js to 1 to activate it by default.

Documentation

Mandatory Checklist

Code validation

• I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
• I triggered all changed lines of code at least once without new errors/warnings/notices.
• I implemented built-in tests to cover the new/changed code.

Code style

• I wrote a self-explanatory code about what it does.
• I protected entry points against unexpected inputs.
• I did not introduce unnecessary complexity.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 815e6391	✅ 100.00% (target: 50.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (815e639)	Report Missing	Report Missing	Report Missing
Head commit (cb1dccc)	38120	16695	43.80%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#7052)	2	2	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[Miraeld]

I'm approving the change as it's ok for me. However,
This is a 3.18 feature, should we merge it onto develop or a 3.18 branch ?

[remyperona]

We should create a branch-3.18 and merge it in it for now

[Miraeld]

Created a feature/3.18 branch and rebased this PR on it :)

[Mai-Saad]

Waiting confirmation about AC here https://wp-media.slack.com/archives/CUKB44GNN/p1730380086011399 => confirmed. @Khadreal can you please check multisite and safe mode scenarios 🙏

[jeawhanlee]

According to the grooming, don't we need to also do this for safe mode as well?

[Mai-Saad]

Related test plan https://wpmediaqa.testrail.io/index.php?/runs/view/922&group_by=cases:section_id&group_order=asc

[Mai-Saad]

@Khadreal Thanks for the update.
Please note that if Autoptimize is enabled with CSS feature on , with fresh install of WPR, we should dimm our Minify js and CSS => now it's checked in UI and dimmed (it shouldn't be checked) and it exists in the meta tag for WPR (it shouldn't)

While expected to be like on 3.17.3.1

• @piotrbak Note that on multisite due to Multisite: Settings are not removed from the wp_options table for subsites when uninstalling WP Rocket #3889, Minify feature may not be enabled by default on subsite with fresh install

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.01% (target: -0.10%)	✅ 55.56% (target: 50.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (ce94d1f)	38262	16746	43.77%
Head commit (f3667a4)	38269 (+7)	16747 (+1)	43.76% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#7052)	9	5	55.56%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

[remyperona]

This should not be happening

[remyperona]

If we use the rocket_first_install_options filter, there shouldn't be any update_rocket_option() call since the option itself doesn't exist yet.

setting the array value to 0 should be enough.

[wordpressfan]

Totally agree with @remyperona
@Khadreal can u replicate the issue mentioned by Mai? for me I can't (after removing the callback rocket_maybe_disable_minification)