Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #7038 Activate minification by default #7052

Open
wants to merge 8 commits into
base: feature/3.18
Choose a base branch
from
+29 −22
Open

Closes #7038 Activate minification by default #7052

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cd1f319
:sparkles: Change js/css value to 1 -- :closes: #7038
Khadreal Oct 22, 2024
b534476
Update test
Khadreal Oct 22, 2024
b1ad1d8
Revert default minfication for safe mode
Khadreal Nov 7, 2024
cb1dccc
fix test
Khadreal Nov 7, 2024
b9985d1
Merge branch 'feature/3.18' into enhancement/activate-minification#7038
Khadreal Dec 11, 2024
d403ae4
Add action for autoptimise when wpr is already installed
Khadreal Dec 11, 2024
3669a7f
Create filter callback for autoptimise
Khadreal Dec 11, 2024
f3667a4
change method name
Khadreal Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions inc/Engine/Admin/Deactivation/DeactivationIntent.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ public function activate_safe_mode() {
'lazyload' => 0,
'lazyload_iframes' => 0,
'lazyload_youtube' => 0,
'minify_css' => 0,
'minify_js' => 0,
'minify_css' => 1,
'minify_js' => 1,
'minify_concatenate_js' => 0,
'defer_all_js' => 0,
'delay_js' => 0,
Expand Down
4 changes: 2 additions & 2 deletions inc/admin/upgrader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ function rocket_first_install() {
'lazyload' => 0,
'lazyload_iframes' => 0,
'lazyload_youtube' => 0,
'minify_css' => 0,
'minify_css' => 1,
'minify_css_key' => $minify_css_key,
'minify_js' => 0,
'minify_js' => 1,
'minify_js_key' => $minify_js_key,
'minify_concatenate_js' => 0,
'minify_google_fonts' => 1,
Expand Down
4 changes: 2 additions & 2 deletions tests/Fixtures/inc/Engine/Admin/Deactivation/DeactivationIntent/activateSafeMode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
'lazyload' => 0,
'lazyload_iframes' => 0,
'lazyload_youtube' => 0,
'minify_css' => 0,
'minify_js' => 0,
'minify_css' => 1,
'minify_js' => 1,
'minify_concatenate_js' => 0,
'defer_all_js' => 0,
'delay_js' => 0,
Expand Down
4 changes: 2 additions & 2 deletions tests/Fixtures/inc/admin/rocketFirstInstall.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
'lazyload' => 0,
'lazyload_iframes' => 0,
'lazyload_youtube' => 0,
'minify_css' => 0,
'minify_css' => 1,
'minify_css_key' => 'minify_css_key_uniqid',
'minify_js' => 0,
'minify_js' => 1,
'minify_js_key' => 'minify_js_key_uniqid',
'minify_concatenate_js' => 0,
'minify_google_fonts' => 1,
Expand Down
Loading