feat: seperate workspaces #1952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonbahl
added
the
type: chore
|
theodesp
approved these changes
Sep 13, 2024
|
@jasonbahl a few ci/cd errors there before we can merge. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 84.98% | 1041/1225 |
| 🟡 | Branches | 66.77% (+0.07% 🔼) |
651/975 |
| 🟢 | Functions | 85.06% | 148/174 |
| 🟢 | Lines | 84.61% (-0.08% 🔻) |
1006/1189 |
Test suite run failed
Failed tests: 12/148. Failed suites: 3/26.
● renders a default list of nodes in the primary section if seedNode is not provided
expect(received).toMatchInlineSnapshot(snapshot)
Snapshot name: `renders a default list of nodes in the primary section if seedNode is not provided 1`
- Snapshot - 1
+ Received + 1
- [
+ Array [
"WordPress",
"",
"GraphiQL IDE",
]
279 | expect(items.length).toBe(expectedLen);
280 | const toolBarNames = items.map((item) => item.textContent);
> 281 | expect(toolBarNames).toMatchInlineSnapshot(expectedContent);
| ^
282 | }
283 |
at testToolBarNode (tests/components/Toolbar/Toolbar.test.tsx:281:24)
at Object.<anonymous> (tests/components/Toolbar/Toolbar.test.tsx:107:3)
● renders an Edit Post Node, in the primary section if seedNode is provided
expect(received).toMatchInlineSnapshot(snapshot)
Snapshot name: `renders an Edit Post Node, in the primary section if seedNode is provided 1`
- Snapshot - 1
+ Received + 1
- [
+ Array [
"WordPress",
"Edit Post",
"GraphiQL IDE",
]
279 | expect(items.length).toBe(expectedLen);
280 | const toolBarNames = items.map((item) => item.textContent);
> 281 | expect(toolBarNames).toMatchInlineSnapshot(expectedContent);
| ^
282 | }
283 |
at testToolBarNode (tests/components/Toolbar/Toolbar.test.tsx:281:24)
at Object.<anonymous> (tests/components/Toolbar/Toolbar.test.tsx:133:3)
● renders an Account Node in the secondary section
expect(received).toMatchInlineSnapshot(snapshot)
Snapshot name: `renders an Account Node in the secondary section 1`
- Snapshot - 1
+ Received + 1
- [
+ Array [
"Howdy, Edit ProfileLog Out",
"",
"Edit Profile",
"Log Out",
]
279 | expect(items.length).toBe(expectedLen);
280 | const toolBarNames = items.map((item) => item.textContent);
> 281 | expect(toolBarNames).toMatchInlineSnapshot(expectedContent);
| ^
282 | }
283 |
at testToolBarNode (tests/components/Toolbar/Toolbar.test.tsx:281:24)
at Object.<anonymous> (tests/components/Toolbar/Toolbar.test.tsx:157:3)
● renders an Edit Post Node if seedNode is not provided and is preview
expect(received).toMatchInlineSnapshot(snapshot)
Snapshot name: `renders an Edit Post Node if seedNode is not provided and is preview 1`
- Snapshot - 1
+ Received + 1
- [
+ Array [
"WordPress",
"",
"GraphiQL IDE",
]
279 | expect(items.length).toBe(expectedLen);
280 | const toolBarNames = items.map((item) => item.textContent);
> 281 | expect(toolBarNames).toMatchInlineSnapshot(expectedContent);
| ^
282 | }
283 |
at testToolBarNode (tests/components/Toolbar/Toolbar.test.tsx:281:24)
at Object.<anonymous> (tests/components/Toolbar/Toolbar.test.tsx:180:3)
● does not render an Edit Post Node if there is no seedNode and it is not a preview
expect(received).toMatchInlineSnapshot(snapshot)
Snapshot name: `does not render an Edit Post Node if there is no seedNode and it is not a preview 1`
- Snapshot - 1
+ Received + 1
- [
+ Array [
"WordPress",
"",
"GraphiQL IDE",
]
279 | expect(items.length).toBe(expectedLen);
280 | const toolBarNames = items.map((item) => item.textContent);
> 281 | expect(toolBarNames).toMatchInlineSnapshot(expectedContent);
| ^
282 | }
283 |
at testToolBarNode (tests/components/Toolbar/Toolbar.test.tsx:281:24)
at Object.<anonymous> (tests/components/Toolbar/Toolbar.test.tsx:202:3)
● Uses `toolbarNodes` hook to add nodes
expect(received).toMatchInlineSnapshot(snapshot)
Snapshot name: `Uses \`toolbarNodes\` hook to add nodes 1`
- Snapshot - 1
+ Received + 1
- [
+ Array [
"WordPress",
"Edit Post",
"GraphiQL IDE",
"Test Node",
]
279 | expect(items.length).toBe(expectedLen);
280 | const toolBarNames = items.map((item) => item.textContent);
> 281 | expect(toolBarNames).toMatchInlineSnapshot(expectedContent);
| ^
282 | }
283 |
at testToolBarNode (tests/components/Toolbar/Toolbar.test.tsx:281:24)
at Object.<anonymous> (tests/components/Toolbar/Toolbar.test.tsx:234:3)
● withFaust › it applies a default redirects config
expect(received).toMatchInlineSnapshot(snapshot)
Snapshot name: `withFaust it applies a default redirects config 1`
- Snapshot - 7
+ Received + 7
@@ -1,22 +1,22 @@
- [
- {
+ Array [
+ Object {
"destination": "/preview",
- "has": [
- {
+ "has": Array [
+ Object {
"key": "preview",
"type": "query",
"value": "true",
},
],
"permanent": false,
"source": "/((?!preview).*)",
},
- {
+ Object {
"destination": "/preview",
- "has": [
- {
+ "has": Array [
+ Object {
"key": "preview",
"type": "query",
"value": "true",
},
],
29 | );
30 | const redirects = await finalConfig.redirects!();
> 31 | expect(redirects).toMatchInlineSnapshot(`
| ^
32 | [
33 | {
34 | "destination": "/preview",
at Object.<anonymous> (tests/config/withFaust.test.ts:31:23)
● withFaust › it allows a custom preview destination
expect(received).toMatchInlineSnapshot(snapshot)
Snapshot name: `withFaust it allows a custom preview destination 1`
- Snapshot - 10
+ Received + 10
@@ -1,34 +1,34 @@
- [
- {
+ Array [
+ Object {
"destination": "/demo",
- "has": [
- {
+ "has": Array [
+ Object {
"key": "preview",
"type": "query",
"value": "true",
},
],
"permanent": false,
"source": "/((?!demo).*)",
},
- {
+ Object {
"destination": "/preview",
- "has": [
- {
+ "has": Array [
+ Object {
"key": "preview",
"type": "query",
"value": "true",
},
],
"permanent": false,
"source": "/((?!preview).*)",
},
- {
+ Object {
"destination": "/preview",
- "has": [
- {
+ "has": Array [
+ Object {
"key": "preview",
"type": "query",
"value": "true",
},
],
64 | });
65 | const redirects = await finalConfig.redirects!();
> 66 | expect(redirects).toMatchInlineSnapshot(`
| ^
67 | [
68 | {
69 | "destination": "/demo",
at Object.<anonymous> (tests/config/withFaust.test.ts:66:23)
● createSitemapIndex() › returns a sitemap index with no sitemaps
expect(received).toMatchSnapshot()
Snapshot name: `createSitemapIndex() returns a sitemap index with no sitemaps 1`
- Snapshot - 0
+ Received + 0
<?xml version="1.0" encoding="UTF-8"?>
<sitemapindex xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
</sitemapindex>
9 |
10 | expect(res.headers.get('Content-Type')).toBe('application/xml');
> 11 | expect(xml).toMatchSnapshot();
| ^
12 | });
13 |
14 | it('returns a sitemap index with specified sitemaps', async () => {
at Object.<anonymous> (tests/server/sitemaps/sitemapUtils.test.ts:11:17)
● createSitemapIndex() › returns a sitemap index with specified sitemaps
expect(received).toMatchSnapshot()
Snapshot name: `createSitemapIndex() returns a sitemap index with specified sitemaps 1`
- Snapshot - 0
+ Received + 0
@@ -6,5 +6,5 @@
</sitemap><sitemap>
<loc>http://localhost:3000/page-sitemap.xml</loc>
</sitemap>
</sitemapindex>
28 |
29 | expect(res.headers.get('Content-Type')).toBe('application/xml');
> 30 | expect(xml).toMatchSnapshot();
| ^
31 | });
32 | });
33 |
at Object.<anonymous> (tests/server/sitemaps/sitemapUtils.test.ts:30:17)
● createSitemap() › returns a sitemap with no links
expect(received).toMatchSnapshot()
Snapshot name: `createSitemap() returns a sitemap with no links 1`
- Snapshot - 0
+ Received + 0
<?xml version="1.0" encoding="UTF-8"?>
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
</urlset>
40 |
41 | expect(res.headers.get('Content-Type')).toBe('application/xml');
> 42 | expect(xml).toMatchSnapshot();
| ^
43 | });
44 |
45 | it('returns a sitemap with specified urls', async () => {
at Object.<anonymous> (tests/server/sitemaps/sitemapUtils.test.ts:42:17)
● createSitemap() › returns a sitemap with specified urls
expect(received).toMatchSnapshot()
Snapshot name: `createSitemap() returns a sitemap with specified urls 1`
- Snapshot - 0
+ Received + 0
@@ -25,5 +25,5 @@
</url>
</urlset>
72 |
73 | expect(res.headers.get('Content-Type')).toBe('application/xml');
> 74 | expect(xml).toMatchSnapshot();
| ^
75 | });
76 | });
77 |
at Object.<anonymous> (tests/server/sitemaps/sitemapUtils.test.ts:74:17)
Report generated by 🧪jest coverage report action from 4ec11be
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! Four Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
- move expeerimental packages to their own directory
- run `npm run format`
- npm run format
- update package.json for @faustwp/blocks to use relative path to @faustwp/core
…ore blocks as core is a dependency of blocks - add sass as dependency to faustwp-core
theodesp
force-pushed
the
feat/separate-workspace
branch
2 times, most recently
from
3c952cf
to
ab25692
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This separates out the workspaces to help reduce the clutter created when running
npm install.The
/examplesdirectory are not intended to be workspace packages, so the dependencies declared in each example should be isolated to that example and not included when installing dependencies for the packages.Fix Workflows
E2E Test Plugin (legacy)Related Issue(s):
Testing
I symlinked my local copy of
acf.wpgraphql.comto this local copy of@faustwp/blocks, then ran my site and it was able to build.In addition to the package.json changes in this PR, we still need to symlink react from the package we're npm linking in our project.
So, in
acf.wpgraphql.comI didnpm link @faustwp/blocksand then withinfaustjs/packages/blocksI had tonpm link /path/to/acf.wpgraphql.com/node_modules/reactfor local development to work without the multiple versions of react errorsee: https://legacy.reactjs.org/warnings/invalid-hook-call-warning.html#duplicate-react
Screenshots
Here you can see that in my
acf.wpgraphql.comproject I have usednpm link @faustwp/blocks:npm list | grep faustThen in
faustjs/packages/blocksI have react linked back to myacf.wpgraphql.comproject via running:npm link /Users/jason.bahl/Sites/libs/acf.wpgraphql.com/node_modules/reactnpm list | grep reactNow I can successfully run
npm run devwithinacf.wpgraphql.comand it builds and runs without any errors.Before
Before this PR, we cannot npm link react back to the
acf.wpgraphql.comproject because of conflicts caused by the examples dependencies and the packages dependencies..After
After this PR, following the
npm linksteps above, we are able to successfully link react frompackages/blocksback to the project (acf.wpgraphql.comin this case) run the project locally without issue. We can also do things like add console.log statements to thecomponents/WordPressBlockViewer.tsxcomponent and see it output with "fast refresh"Documentation Changes
@todoUpdate LOCAL_DEVELOPMENT.md