Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use service navigation component for navigation #316

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

paulrobertlloyd
Copy link
Collaborator

Replaces the X-GOVUK primary navigation component that’s used to render navigation items with the new service navigation component from the GOV.UK Design System.

So that this can be a MINOR release, existing options map to the equivalent options in the new component.

For the next MAJOR breaking release, we can investigate allowing all options for the service navigation component to be passed down, and thus changing plugin options.

Copy link
Contributor

@frankieroberto frankieroberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@paulrobertlloyd paulrobertlloyd merged commit 813ba42 into main Sep 2, 2024
2 checks passed
@paulrobertlloyd paulrobertlloyd deleted the service-navigation branch September 2, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants