feat: accept numbers for NUM_AS_HEX
#491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the official specs indicate that `NUM_AS_HEX` must be strings, some Starknet libraries expect numbers to be acceptable in certain cases. Adding support for this technically breaks the specs but it's acceptable since it's only on the deserialization side. Also changes the `NumAsHex` implementation to remove the unnecessary allocation for `String`. This makes deserialization slightly more efficient.
This was referenced Nov 1, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the official specs indicate that
NUM_AS_HEXmust be strings, some Starknet libraries expect numbers to be acceptable in certain cases. Adding support for this technically breaks the specs but it's acceptable since it's only on the deserialization side.Also changes the
NumAsHeximplementation to remove the unnecessary allocation forString. This makes deserialization slightly more efficient.