Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated property to FileTarget::class. #19970

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Remove deprecated property to FileTarget::class. #19970

merged 1 commit into from
Sep 23, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Sep 22, 2023

PR Summary

  • Removal of Deprecated rotateByCopy Property and Comments
    The outdated rotateByCopy property and any comments related to it were removed from the FileTarget class, specifically: the property itself, and a deprecated comment.

  • Updated Documentation for rotateByCopy Property
    The PHPDoc comment, which provides documentation for developers, for the rotateByCopy property in the FileTarget class was updated. This includes changes to the @deprecated tag, which marks the method as deprecated, and the @since tag which marks the version from which the method was introduced or changed.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +39.06% 🎉

Comparison is base (6618aa8) 28.12% compared to head (5311fac) 67.18%.

Additional details and impacted files
@@              Coverage Diff              @@
##                2.2   #19970       +/-   ##
=============================================
+ Coverage     28.12%   67.18%   +39.06%     
  Complexity    11209    11209               
=============================================
  Files           424      424               
  Lines         35617    35617               
=============================================
+ Hits          10016    23930    +13914     
+ Misses        25601    11687    -13914     
Files Changed Coverage Δ
framework/log/FileTarget.php 85.71% <ø> (+85.71%) ⬆️

... and 203 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizley bizley merged commit 3f19873 into yiisoft:2.2 Sep 23, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants