Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated property to FileTarget::class. #19970

Merged
merged 1 commit into from
Sep 23, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions framework/log/FileTarget.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@
* files are moved backwards by one place, i.e., '.2' to '.3', '.1' to '.2', and so on.
* The property [[maxLogFiles]] specifies how many history files to keep.
*
* Since 2.0.46 rotation of the files is done only by copy and the
* `rotateByCopy` property is deprecated.
*
* @author Qiang Xue <[email protected]>
* @since 2.0
*/
Expand Down Expand Up @@ -61,22 +58,6 @@ class FileTarget extends Target
* but read-only for other users.
*/
public $dirMode = 0775;
/**
* @var bool Whether to rotate log files by copy and truncate in contrast to rotation by
* renaming files. Defaults to `true` to be more compatible with log tailers and windows
* systems which do not play well with rename on open files. Rotation by renaming however is
* a bit faster.
*
* The problem with windows systems where the [rename()](https://www.php.net/manual/en/function.rename.php)
* function does not work with files that are opened by some process is described in a
* [comment by Martin Pelletier](https://www.php.net/manual/en/function.rename.php#102274) in
* the PHP documentation. By setting rotateByCopy to `true` you can work
* around this.
* @deprecated since 2.0.46 and setting it to false has no effect anymore
* since rotating is now always done by copy.
*/
public $rotateByCopy = true;


/**
* Initializes the route.
Expand Down
Loading