-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHP 8.4] Fixes for implicit nullability deprecation #20133
Conversation
Fixes all issues that emit deprecation notices on PHP 8.4 for implicit nullable parameter type declarations. Related to yiisoft#20128. This is against the `master` branch while the other PR targets the `2.2` branch. See: - [RFC](https://wiki.php.net/rfc/deprecate-implicitly-nullable-types) - [PHP 8.4: Implicitly nullable parameter declarations deprecated](https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated)
PR Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20133 +/- ##
============================================
- Coverage 64.82% 63.64% -1.19%
Complexity 11376 11376
============================================
Files 429 429
Lines 37074 37073 -1
============================================
- Hits 24034 23594 -440
- Misses 13040 13479 +439 ☔ View full report in Codecov by Sentry. |
Thank you! |
Thank you for triaging and coordinating this. |
Fixes all issues that emit deprecation notices on PHP 8.4 for implicit nullable parameter type declarations. Related to #20128. This is against the
master
branch while the other PR targets the2.2
branch.See: