Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issue due to the outdated 'time' module #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yurivict
Copy link

Reference: haskell/time#145

@arrowd
Copy link

arrowd commented Feb 17, 2023

This change is certainly wrong, it should be

time >= 1.8.0.2 && <1.13

@yurivict
Copy link
Author

This change is certainly wrong, it should be

Why time >= 1.8.0.2? time-1.8.0.2 doesn't build. time-1.9.3 also doesn't build.
Why <1.13 and not say 1.12.3?

@dwRchyngqxs
Copy link
Collaborator

Verismith builds just fine on my Arch Linux and Ubuntu with time < 1.10.

@yurivict
Copy link
Author

It fails on FreeBSD with this error: #85

@dwRchyngqxs
Copy link
Collaborator

It was just a counter argument to time < 1.10 not building. The change proposed by @arrowd is easy to apply, does it prevent Verismith from building using your setup?

@yurivict
Copy link
Author

With the patch proposed by arrowd the build fails. The FreeBSD framework uses time-1.9.3 that fails with the above linked error.

I also don't understand the desire to keep the version range for 'time' low. If some versions below a certain threshold are known to fail on some systems - doesn't it make sense to make the lower limit higher?

@arrowd
Copy link

arrowd commented Feb 18, 2023

The FreeBSD framework uses time-1.9.3 that fails with the above linked error.

Our Ports do not use any specific Haskell packages. The framework only calls cabal to create a build plan which is then copied to the Makefile. The plan gets created for GHC/Cabal versions we currently have in the tree, but other distributions may have different versions. This results in different plans, in which 1.9.3 seem to work.

So, the correct solution is to only extend version bounds, not shrink them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants