Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation for multi templates in Wrap #202

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Added documentation for multi templates in Wrap #202

merged 1 commit into from
Jul 31, 2024

Conversation

kalisp
Copy link
Member

@kalisp kalisp commented Jul 16, 2024 •
edited
Loading

Documentation for ynput/ayon-wrap#6

@kalisp kalisp requested a review from MustafaJafar July 16, 2024 12:51
@ynbot
Copy link

ynbot commented Jul 16, 2024

Task linked: AY-5403 Provide dialog to choose from multiple template files per task in Wrap

@kalisp kalisp mentioned this pull request Jul 16, 2024
Merged
MustafaJafar
MustafaJafar reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave the addon a try to check the settings.
I found something different from the screenshots in the PR.

I've wrap addon version: 0.0.3-dev.1
image

Edit: I checked out the correct branch and I can see settings correctly
image

@MustafaJafar MustafaJafar self-requested a review July 31, 2024 07:57
MustafaJafar
MustafaJafar approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

@kalisp kalisp merged commit 2a35376 into main Jul 31, 2024
4 checks passed
@kalisp kalisp deleted the feature/AY-5403_Provide-dialog-to-choose-from-multiple-template-files-per-task-in-Wrap branch July 31, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MustafaJafar MustafaJafar MustafaJafar approved these changes

Assignees

@MustafaJafar MustafaJafar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalisp @ynbot @MustafaJafar