Dialog to choose from multiple template files per task in wrap #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks if current context has configuration for multiple templates. If not it skips Workfiles tool.
Will be used in Workfiles tool to get templates. I prefer simpler interface for the tool, profile could be passed directly too, but it seems nicer to run the tool only on the context and let prepare data itself.
Added here as it is depending of multi profiles, `ayon+anatomy://ayon_test/templates/work` would be used even if not multi templates should be used. `ayon+settings://core/tools/Workfiles/workfile_template_profiles?project=ayon_test` would duplicate tasks that should have multi templates. It is not expected that there would be need for multiple path templates
Tried to inherit from WorkAreaFilesModel from Workfile app, didn't work. Had to copy and cleaned up code from there.
Workfile app sets env var to propagate new or opening existing workfile.
<_> pattern is problematic for basic formatting and there is no actual field to pass comment in.
Checks presence of workfiles in workarea to set enable state for Open and Create New buttons
launch_args contains old path to workfile, not from Workfile app for multiple templates per task.
Error in filling of placeholder shouldn't stop launching of application.
iLLiCiTiT
reviewed
Jul 16, 2024
iLLiCiTiT
reviewed
Jul 16, 2024
…from-multiple-template-files-per-task-in-Wrap # Conflicts: # client/ayon_wrap/api/lib.py # client/ayon_wrap/hooks/pre_replace_placeholders.py
After review comment, it should be in Anatomy, added to documentation and switched to pulling and formatting it from Anatomy.
This way it should be safer against circular imports
|
Added documentation PR ynput/ayon-documentation#202 |
…template-files-per-task-in-Wrap' of https://github.com/ynput/ayon-wrap into feature/AY-5403_Provide-dialog-to-choose-from-multiple-template-files-per-task-in-Wrap
iLLiCiTiT
reviewed
Jul 16, 2024
| @@ -37,6 +37,9 @@ def __init__(self, launch_data): | |||
|
|
|||
| project_entity = ayon_api.get_project(project_name) | |||
|
|
|||
| # template name in Anatomy | |||
| self.wrap_template_name = "wrap_multi" | |||
There was a problem hiding this comment.
If you've already change it to use anatomy then use get_workfile_template_key to determine which should be used.
There was a problem hiding this comment.
This workflow is applicable only for specific profiles, to be able to use Anatomy, I would need to duplicate that logic there.
There was a problem hiding this comment.
I don't understand, you are using anatomy, but also hardcoding template name... You should not hardcode template name, you should use whatever is defined in workfile settings, and studio should add the template (they should be able to name it whatever they want) and add it to profiles for wrap host.
iLLiCiTiT
reviewed
Jul 16, 2024
Button state must be refreshed after each template_change. Proxy model counted it wrong (empty items included).
…template-files-per-task-in-Wrap' of https://github.com/ynput/ayon-wrap into feature/AY-5403_Provide-dialog-to-choose-from-multiple-template-files-per-task-in-Wrap
Co-authored-by: Jakub Trllo <[email protected]>
exec_() should be enough Co-authored-by: Jakub Trllo <[email protected]>
…from-multiple-template-files-per-task-in-Wrap
No real Wrap host, creator and publish can only run in Traypublisher.
…template-files-per-task-in-Wrap' of https://github.com/ynput/ayon-wrap into feature/AY-5403_Provide-dialog-to-choose-from-multiple-template-files-per-task-in-Wrap
iLLiCiTiT
approved these changes
Aug 8, 2024
kalisp
deleted the
feature/AY-5403_Provide-dialog-to-choose-from-multiple-template-files-per-task-in-Wrap
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds possibility to assign multiple Wrap templates for single task, as it is recommended to split Wrap logic into more workfiles for technical reasons.
This functionality is configured in
ayon+settings://wrap/multiple_templates_per_tasks?project=ayon_testwhere multiplestepscould be configured for profile of task name and type.If matching profile is found during start of Wrap, artist is shown simple Workfile app that shows
App allows creation (copy of template to workarea) of new workfile, or selection of any existing workfile.
This functionality is not required, if single workfile template per task is enough, ordinary
ayon+settings://wrap/workfile_builder?project=ayon_testshould be used.