Allow to set an explicit AOV identifier for USD render product using attribute ayon:aov_identifier
#120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…attribute `ayon:aov_identifier`
BigRoy
added
the
type: enhancement
|
Hey! @BigRoy I tested this, The above is the error log, when I tried to publish. I was just wondering where should I add the wrangle?
|
|
tested again: It got published successfully, skipping the bty and publishing the dcm alone |
|
@krishnaavril So did it work for your use case? :) By the way - with this fix you should be able to publish both the render products just fine from one publish instance in one go. |
|
No @BigRoy The best way I would imagine is I also noticed if we keep the log(checkpoint) option enabled in labs karma, ayon publishing checkpoint as new layer, we need same approach for dcm |
The thing is that This images shows what I mean. Let me create a quick PR. |
| @@ -166,6 +166,15 @@ def get_aov_identifier(self, render_product): | |||
| str: The AOV identifier | |||
|
|
|||
| """ | |||
| # Allow explicit naming through custom attribute on the render product | |||
| aov_identifier = render_product.GetPrim().GetAttribute( | |||
| "ayon:aov_identifier").Get() | |||
There was a problem hiding this comment.
It was returning None on my side because my wrangle was time dependent.
This fixes the issue.
Suggested change
| "ayon:aov_identifier").Get() | |
| "ayon:aov_identifier").Get(time=0) |
There was a problem hiding this comment.
Note: using time 0 may not be recommended although it's being used with render targets here
Anyways, we can use the earliest time.
but keep in mind, we still need to add this 👇 import at the top.
from pxr import Usd
Suggested change
| "ayon:aov_identifier").Get() | |
| "ayon:aov_identifier").Get(time=Usd.TimeCode.EarliestTime()) |
2 tasks
|
Here are a test run after applying the suggested fix above.
|
| if aov_identifier: | ||
| self.log.debug( | ||
| "Using explicit ayon:aov_identifier on render product" | ||
| " '{render_product}': {aov_identifier}") |
There was a problem hiding this comment.
There's a missing f here
Suggested change
| " '{render_product}': {aov_identifier}") | |
| f" '{render_product}': {aov_identifier}") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Allow to set an explicit AOV identifier for USD render product using attribute
ayon:aov_identifierAdditional info
This is a way to override the default behavior that defines what "AOV" identifier is computed for a Render Product. You can now set a string attribute on the Render Product prim called
ayon:aov_identifier.For example a Attribute Wrangle LOP could do:
So that publish logic will make that render product interpreted as the "dcm" AOV - separating it from other layers.
This may fix (or workaround) #105
Testing notes: