Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set an explicit AOV identifier for USD render product using attribute ayon:aov_identifier #120

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Allow to set an explicit AOV identifier for USD render product using attribute ayon:aov_identifier #120

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
01aaa9b
Allow to set an explicit AOV identifier for USD render product using …
BigRoy Oct 11, 2024
c0fdc23
Trigger GetAttribute on the prim
BigRoy Oct 15, 2024
16647de
Merge branch 'develop' into enhancement/usd_allow_custom_aov_identifier
BigRoy Oct 31, 2024
cffb2a5
Merge branch 'develop' into enhancement/usd_allow_custom_aov_identifier
BigRoy Nov 13, 2024
99003cc
Merge branch 'develop' into enhancement/usd_allow_custom_aov_identifier
MustafaJafar Nov 19, 2024
8d46759
Merge branch 'develop' into enhancement/usd_allow_custom_aov_identifier
MustafaJafar Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions client/ayon_houdini/plugins/publish/collect_render_products.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,15 @@ def get_aov_identifier(self, render_product):
str: The AOV identifier

"""
# Allow explicit naming through custom attribute on the render product
aov_identifier = render_product.GetPrim().GetAttribute(
"ayon:aov_identifier").Get()
Copy link
Contributor

@MustafaJafar MustafaJafar Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was returning None on my side because my wrangle was time dependent.
This fixes the issue.

Suggested change
"ayon:aov_identifier").Get()
"ayon:aov_identifier").Get(time=0)

image

Copy link
Contributor

@MustafaJafar MustafaJafar Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: using time 0 may not be recommended although it's being used with render targets here

Anyways, we can use the earliest time.
but keep in mind, we still need to add this 👇 import at the top.

from pxr import Usd
Suggested change
"ayon:aov_identifier").Get()
"ayon:aov_identifier").Get(time=Usd.TimeCode.EarliestTime())

if aov_identifier:
self.log.debug(
"Using explicit ayon:aov_identifier on render product"
" '{render_product}': {aov_identifier}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a missing f here

Suggested change
" '{render_product}': {aov_identifier}")
f" '{render_product}': {aov_identifier}")

return str(aov_identifier)

targets = render_product.GetOrderedVarsRel().GetTargets()
if len(targets) > 1:
# Cryptomattes usually are combined render vars, for example:
Expand Down