-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage and Local directory paths #144
Merged
iLLiCiTiT
merged 17 commits into
develop
from
feature/AY-5795_Ability-to-set-AYON-local-folder-location-
Aug 15, 2024
Merged
Storage and Local directory paths #144
iLLiCiTiT
merged 17 commits into
develop
from
feature/AY-5795_Ability-to-set-AYON-local-folder-location-
Aug 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64qam
approved these changes
Aug 12, 2024
…-folder-location-
…-folder-location- # Conflicts: # common/ayon_common/utils.py
iLLiCiTiT
deleted the
feature/AY-5795_Ability-to-set-AYON-local-folder-location-
branch
August 15, 2024 15:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
AYON launcher defines more generic environment variables to define storage and local directory. A directory where are stored files that can be shared across multiple machines
AYON_LAUNCHER_STORAGE_DIR
and directory where are stored user/machine specific filesAYON_LAUNCHER_LOCAL_DIR
. Those 2 should be used for whatever is related to AYON and should be stored.Additional info
Previously defined environment variables
AYON_ADDONS_DIR
andAYON_DEPENDENCIES_DIR
did not cover all files that are used during AYON processes. Using more abstract concept of "shared" directory and "local" directory is easier to explain and maintain.Just because it can be shared does not mean it won't break if it is shared. I'm not sure what will happen if 2 AYON launchers on different machines will try to download addons, dependency packages or any other file to the same location at the same time.
This is initial part of the idea. With this available in AYON launcher it is necessary to add api functions to ayon-core and then use the functions in other addons.
With only this PR is might be dangerous to change
AYON_LAUNCHER_LOCAL_DIR
as ayon-core might look to other places. I didn't test it and did not validate code in ayon-core to find out how much danger it is (that's my next step).Important
This change requires modification of #112 as shim has to know where to find
executables.json
.Testing notes:
AYON_LAUNCHER_STORAGE_DIR
to other place on your machine.AYON_LAUNCHER_LOCAL_DIR
and local files.