Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default product type for the VDB cache simple creator #13

Merged

Conversation

BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Sep 9, 2024

Changelog Description

The 'vdbcache' product type is used for product types filtering currently for Houdini and Maya based loaders so is a way more sensible default.

Additional info

I don't know of any loader that would work with the vdb product type currently.

Testing notes:

  1. Publish VDB via tray publisher
  2. Should be able to load it into Maya and Houdini

The 'vdbcache' product type is used for product types filtering currently for Houdini and Maya based loaders so is a way more sensible default.
@BigRoy BigRoy added the type: bug Something isn't working label Sep 9, 2024
@BigRoy BigRoy self-assigned this Sep 9, 2024
@BigRoy
Copy link
Contributor Author

BigRoy commented Sep 9, 2024

@iLLiCiTiT another approach would be to remove the filtering on the loaders and just filter by extension instead. However, it'd still make the tray publisher product type differ from the maya and houdini published vdbs so I think this 'fix' here may be more suitable?

Copy link
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Published and loaded successfully
image

@iLLiCiTiT
Copy link
Member

@iLLiCiTiT another approach would be to remove the filtering on the loaders and just filter by extension instead. However, it'd still make the tray publisher product type differ from the maya and houdini published vdbs so I think this 'fix' here may be more suitable?

I even didn't know we have vdb here (I don't know what vdb is).

@BigRoy
Copy link
Contributor Author

BigRoy commented Sep 10, 2024

Stupid me - I thought your screenshot was the publisher inside Houdini, but it actually is the tray publisher.
@moonyuet Could you just approve again? :)

@BigRoy BigRoy requested a review from moonyuet September 10, 2024 09:49
@BigRoy BigRoy merged commit ea4e2d2 into ynput:develop Sep 10, 2024
1 check passed
@BigRoy BigRoy deleted the bugfix/vdbcache_default_simple_creators branch September 10, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants