Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(shortint): new parameters #1886

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

chore(shortint): new parameters #1886

wants to merge 10 commits into from

Conversation

nsarlin-zama
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Dec 17, 2024
@nsarlin-zama nsarlin-zama force-pushed the ns/chore/params_zkv1 branch 2 times, most recently from 25d6bb9 to 92ea542 Compare December 17, 2024 15:07
@zama-bot zama-bot removed the approved label Dec 19, 2024
@nsarlin-zama nsarlin-zama changed the title chore(shortint): new parameters for zkv1 chore(shortint): new parameters Dec 19, 2024
@nsarlin-zama nsarlin-zama force-pushed the ns/chore/params_zkv1 branch 4 times, most recently from 7858942 to b173358 Compare December 20, 2024 08:53
@nsarlin-zama nsarlin-zama requested a review from soonum December 20, 2024 08:59
@nsarlin-zama nsarlin-zama force-pushed the ns/chore/params_zkv1 branch 2 times, most recently from 9b313f2 to 0fab62b Compare December 20, 2024 10:41
@soonum
Copy link
Contributor

soonum commented Dec 20, 2024 •
edited
Loading

Should we set aliases for Gaussian common parameters (like 2_2) just like the Tuniform flavour ? @IceTDrinker
We could do it in a different PR as is not changing directly the behavior of the current implementation.

soonum
soonum approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@soonum soonum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible and tedious job, thanks a lot @nsarlin-zama !

@zama-bot zama-bot removed the approved label Dec 20, 2024
@zama-bot zama-bot removed the approved label Jan 2, 2025
@nsarlin-zama
Copy link
Contributor Author

I added a new enum inside the CompactPublicKeyEncryptionParameters: SupportedCompactPkeZkScheme. It can take 3 values: ZkNotSupported, V1 and V2.
ZkNotSupported is used when pke parameters are derived from compute paramters and we cannot guess the correct zk version to use.

V1 params will always generate a V1 crs and V2 params a V2 crs, which will make incompatibility issues less likely. However, since the zk version is not stored in the keyswitch paramters, it is still possible to mix pke parameters for v2 with keyswitch parameters for v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceTDrinker IceTDrinker IceTDrinker left review comments

@soonum soonum soonum approved these changes

@tmontaigu tmontaigu tmontaigu approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nsarlin-zama @soonum @tmontaigu @IceTDrinker @zama-bot