-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(shortint): new parameters #1886
Open
nsarlin-zama
wants to merge
12
commits into
main
Choose a base branch
from
ns/chore/params_zkv1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3432b94
chore(shortint): new parameters for tuniform
nsarlin-zama d89c93c
chore(zk): add a test with zkv1 in integer compact list encryption
nsarlin-zama 4a23eb4
chore(shortint): rename wopbs params to LEGACY_
nsarlin-zama 3f420f4
chore(shortint): remove tuniform pbs_ks parameters
nsarlin-zama 387c907
chore(shortint): update gaussian compact pk parameters
nsarlin-zama 531d71a
chore(shortint): update classic gaussian param
nsarlin-zama 1cd88c8
chore(shortint): update multibit gaussian parameters
nsarlin-zama 8676a65
chore(shortint): re-export v0.10 params at top level
nsarlin-zama f1eb675
chore(shortint): move tuniform 0.10 parameters into their own folder
nsarlin-zama a2a54a4
chore(zk)!: store inside the pke params the supported zk scheme
nsarlin-zama 71fb6c5
chore(shortint): update keyswitch 1_1 to 2_2 parameters
nsarlin-zama 3667154
chore(shortint): update compression parameters
nsarlin-zama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
use criterion::Criterion; | ||
use tfhe::prelude::*; | ||
use tfhe::shortint::parameters::PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64; | ||
use tfhe::shortint::parameters::V0_11_PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64; | ||
use tfhe::shortint::prelude::*; | ||
use tfhe::{generate_keys, ConfigBuilder, FheUint64}; | ||
use tfhe_trivium::{TransCiphering, TriviumStreamShortint}; | ||
|
@@ -12,12 +12,12 @@ pub fn trivium_shortint_warmup(c: &mut Criterion) { | |
let underlying_sk: tfhe::shortint::ServerKey = (*hl_server_key.as_ref()).clone().into(); | ||
|
||
let (client_key, server_key): (ClientKey, ServerKey) = | ||
gen_keys(PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64); | ||
gen_keys(V0_11_PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same story here |
||
|
||
let ksk = KeySwitchingKey::new( | ||
(&client_key, Some(&server_key)), | ||
(&underlying_ck, &underlying_sk), | ||
PARAM_KEYSWITCH_1_1_KS_PBS_TO_2_2_KS_PBS, | ||
V0_11_PARAM_KEYSWITCH_1_1_KS_PBS_TO_2_2_KS_PBS, | ||
); | ||
|
||
let key_string = "0053A6F94C9FF24598EB".to_string(); | ||
|
@@ -63,12 +63,12 @@ pub fn trivium_shortint_gen(c: &mut Criterion) { | |
let underlying_sk: tfhe::shortint::ServerKey = (*hl_server_key.as_ref()).clone().into(); | ||
|
||
let (client_key, server_key): (ClientKey, ServerKey) = | ||
gen_keys(PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64); | ||
gen_keys(V0_11_PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64); | ||
|
||
let ksk = KeySwitchingKey::new( | ||
(&client_key, Some(&server_key)), | ||
(&underlying_ck, &underlying_sk), | ||
PARAM_KEYSWITCH_1_1_KS_PBS_TO_2_2_KS_PBS, | ||
V0_11_PARAM_KEYSWITCH_1_1_KS_PBS_TO_2_2_KS_PBS, | ||
); | ||
|
||
let key_string = "0053A6F94C9FF24598EB".to_string(); | ||
|
@@ -109,12 +109,12 @@ pub fn trivium_shortint_trans(c: &mut Criterion) { | |
let underlying_sk: tfhe::shortint::ServerKey = (*hl_server_key.as_ref()).clone().into(); | ||
|
||
let (client_key, server_key): (ClientKey, ServerKey) = | ||
gen_keys(PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64); | ||
gen_keys(V0_11_PARAM_MESSAGE_1_CARRY_1_KS_PBS_GAUSSIAN_2M64); | ||
|
||
let ksk = KeySwitchingKey::new( | ||
(&client_key, Some(&server_key)), | ||
(&underlying_ck, &underlying_sk), | ||
PARAM_KEYSWITCH_1_1_KS_PBS_TO_2_2_KS_PBS, | ||
V0_11_PARAM_KEYSWITCH_1_1_KS_PBS_TO_2_2_KS_PBS, | ||
); | ||
|
||
let key_string = "0053A6F94C9FF24598EB".to_string(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
huh I think this is not correct as the ConfigBuilder is using the default config, not required to change for the release tomorrow, this is purely at the GitHub repo level, please make a note to look for ConfigBuilder::default() usage