Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore some lines for coverage #633

Merged
merged 4 commits into from
Nov 16, 2024
Merged

Conversation

dstansby
Copy link
Contributor

We (well, I) have been a bit sloppy with code coverage recently. This ignores a couple of lines that aren't covered in tests, but don't need to be.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.71%. Comparing base (29995e3) to head (bf2a6e8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #633      +/-   ##
==========================================
- Coverage   99.81%   96.71%   -3.11%     
==========================================
  Files          62       62              
  Lines        2712     2708       -4     
==========================================
- Hits         2707     2619      -88     
- Misses          5       89      +84     
Files with missing lines Coverage Δ
numcodecs/checksum32.py 100.00% <ø> (+1.13%) ⬆️
numcodecs/tests/test_zarr3.py 96.66% <100.00%> (-1.16%) ⬇️

... and 4 files with indirect coverage changes

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David! 🙏

Had a couple questions below

numcodecs/checksum32.py Outdated Show resolved Hide resolved
numcodecs/checksum32.py Outdated Show resolved Hide resolved
numcodecs/tests/test_zarr3.py Outdated Show resolved Hide resolved
numcodecs/tests/test_zarr3.py Outdated Show resolved Hide resolved
@dstansby dstansby added this to the 0.14.1 milestone Nov 16, 2024
@dstansby dstansby merged commit ad1ad67 into zarr-developers:main Nov 16, 2024
25 of 26 checks passed
@jakirkham
Copy link
Member

Thanks David! 🙏

@dstansby dstansby deleted the cov-ignores branch November 17, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants