Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix store creation with latest zarr-python v3 #644

Merged
merged 3 commits into from
Nov 16, 2024

Conversation

dstansby
Copy link
Contributor

See failures at #642.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.81%. Comparing base (5b8c09c) to head (1cb02f7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
+ Coverage   90.08%   99.81%   +9.73%     
==========================================
  Files          62       62              
  Lines        2712     2712              
==========================================
+ Hits         2443     2707     +264     
+ Misses        269        5     -264     
Files with missing lines Coverage Δ
numcodecs/tests/test_zarr3.py 97.82% <100.00%> (+91.30%) ⬆️

... and 1 file with indirect coverage changes

@dstansby dstansby marked this pull request as ready for review November 16, 2024 09:34
@dstansby dstansby added this to the 0.14.1 milestone Nov 16, 2024
@dstansby dstansby merged commit d78cadd into zarr-developers:main Nov 16, 2024
25 of 26 checks passed
@dstansby dstansby mentioned this pull request Nov 16, 2024
@jakirkham
Copy link
Member

Thank you both! 🙏

@dstansby dstansby deleted the zarr-compat branch November 17, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants