Fixed coveralls issues with KeyError and HTTP 422 Unprocessable Entity #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-maier
force-pushed
the
andy/fix-coveralls
branch
3 times, most recently
from
f67fcaa
to
b4723c0
Compare
andy-maier
changed the title
andy-maier
force-pushed
the
andy/fix-coveralls
branch
3 times, most recently
from
c64f985
to
0839db5
Compare
andy-maier
changed the title
andy-maier
force-pushed
the
andy/fix-coveralls
branch
2 times, most recently
from
a90ec99
to
4fe4171
Compare
andy-maier
changed the title
Details:
* Increased minimum version of coveralls to 3.3.0 since it is the first
version that allows overriding the service_job_id parameter via an
environment variable.
* In the test workflow, specified two changes that solved both issues:
* Changed the service name to 'github' (the default is 'github-actions')
* Set the service_job_id request parameter by setting the
COVERALLS_SERVICE_JOB_ID env var to GITHUB_RUN_ID.
* Improved the build ID shown on coveralls.io, to workflow name
plus run number of that workflow. This allows for easier matching
of Github Actions runs and coveralls.io builds.
Signed-off-by: Andreas Maier <[email protected]>
andy-maier
force-pushed
the
andy/fix-coveralls
branch
from
4fe4171
to
dc1c0e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After initially disabling coveralls reporting, I found a solution that seems to work reliably.
It required an update to the Python 2.7 version of coveralls-python on https://github.com/andy-maier/coveralls-python/tree/andy/add-py27.
This PR is ready for merge. No review needed.