Draft: Also prepare the filesystem when a command is given #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
start.sh is run when no command is given when starting a container. But when the makefiles run the container, with a composer install command, we also need to make sure the filesystem got the correct ACLs. To do so, we now prepare the filesystem in a new prepare.sh entrypoint. We use an additional prepare.sh, and not entry.sh, because it allow the projects to extends this, without rewriting entry.sh. This also clean and improve the shell code.
At this point we already expect for www-data to be configured as 1000. Also, we don't chown the group, because then the folder group will keep the default id, which mean be readable to the host user group while docker is run rootless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
start.sh is run when no command is given when starting a container.
But when the makefiles run the container, with a composer install
command, we also need to make sure the filesystem got the correct ACLs.
To do so, we now prepare the filesystem in a new prepare.sh entrypoint.
We use an additional prepare.sh, and not entry.sh, because it allow the
projects to extends this, without rewriting entry.sh.
This also clean and improve the shell code.