Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Also prepare the filesystem when a command is given #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Draft: Also prepare the filesystem when a command is given #22

wants to merge 4 commits into from

Commits on Jun 3, 2024

  1. Also prepare the filesystem when a command is given 

    start.sh is run when no command is given when starting a container.

But when the makefiles run the container, with a composer install
command, we also need to make sure the filesystem got the correct ACLs.

To do so, we now prepare the filesystem in a new prepare.sh entrypoint.

We use an additional prepare.sh, and not entry.sh, because it allow the
projects to extends this, without rewriting entry.sh.

This also clean and improve the shell code.
    @stacyharper
    stacyharper committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    414fe71 View commit details
    Browse the repository at this point in the history

  2. prepare.sh: use www-data explicitely 

    At this point we already expect for www-data to be configured as 1000.

Also, we don't chown the group, because then the folder group will keep the
default id, which mean be readable to the host user group while docker
is run rootless.
    @stacyharper
    stacyharper committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    39c35a1 View commit details
    Browse the repository at this point in the history

  3. prepare.sh: cleaning

    @stacyharper
    stacyharper committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    b5063ce View commit details
    Browse the repository at this point in the history

  4. prepare.sh: add vendor and public www folders

    @stacyharper
    stacyharper committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    90bf48b View commit details
    Browse the repository at this point in the history