Update Gemspec versions #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no reason to block pessimistically (`~>`) to any of these versions. Also add dependencies (bigdecimal) which is warned about in a deprecation warning: ``` /Users/rschneeman/.gem/ruby/3.3.1/gems/get_process_mem-0.2.7/lib/get_process_mem.rb:2: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of get_process_mem-0.2.7 to add bigdecimal into its gemspec. ```
This doesn't directly mean that these versions won't work, but we no longer make claims about their support.
``` $ be standardrb --fix standard: Use Ruby Standard Style (https://github.com/standardrb/standard) lib/puma_worker_killer/puma_memory.rb:78:20: Style/HashConversion: Prefer ary.to_h to Hash[ary]. standard: Run `standardrb --fix-unsafely` to DANGEROUSLY fix one problem. ```
``` /Users/rschneeman/Documents/projects/puma_worker_killer/puma_worker_killer.gemspec:17: warning: global variable `$INPUT_RECORD_SEPARATOR' not initialized ```
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason to block pessimistically (
~>) to any of these versions. Also add dependencies (bigdecimal) which is warned about in a deprecation warning: